feat: add include-import-lib option to bundle Windows import libraries in wheels#3017
Open
feat: add include-import-lib option to bundle Windows import libraries in wheels#3017
include-import-lib option to bundle Windows import libraries in wheels#3017Conversation
…s in wheels Add a new `include-import-lib` option (defaults to false) in `[tool.maturin]` that includes the Windows import library (.dll.lib for MSVC, .dll.a for MinGW) in the built wheel. This enables users who distribute shared libraries via wheels to allow other programs to link against them at compile time. The import library path is extracted directly from cargo's JSON build output (the extra filenames reported alongside the primary artifact), so no extra file copying to staging directories is needed. Supported for all binding types that produce cdylibs/dlls: cffi, uniffi, and pyo3. Closes PyO3#2289
messense
changed the title
include-import-lib option to bundle Windows import libraries in wheels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
include-import-liboption (defaults to false) in[tool.maturin]that includes the Windows import library (.dll.libfor MSVC,.dll.afor MinGW) in the built wheel. This enables users who distribute shared libraries via wheels to allow other programs to link against them at compile time.The import library path is extracted directly from cargo's JSON build output (the extra filenames reported alongside the primary artifact), so no extra file copying to staging directories is needed.
Supported for all binding types that produce cdylibs/dlls: cffi, uniffi, and pyo3.
Closes #2289