feat: build wheels from sdist with --sdist flag#3014
Merged
Conversation
Change `maturin build --sdist` to build the source distribution first, unpack it into a temporary directory, then build wheels from the unpacked sdist. This verifies that the produced sdist is complete and usable. The same sdist-first workflow is also applied to `maturin publish` when `--no-sdist` is not specified. Closes PyO3#2564
messense
force-pushed
the
build-wheels-from-sdist
branch
from
f19caff to
9f3a730
Compare
Member
|
I both really want this and wonder how much we reimplement |
Member
Author
|
Yeah I was also hesitate to implement this in maturin, but the actual code changes are small and provides real benefits, so don't hurt to have it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
maturin build --sdistto build the source distribution first, unpack it into a temporary directory, then build wheels from the unpacked sdist. This verifies that the produced sdist is complete and usable.The same sdist-first workflow is also applied to
maturin publishwhen--no-sdistis not specified.Closes #2564