fix: support maturin develop on Windows ARM with x86 Python#3011
Merged
fix: support maturin develop on Windows ARM with x86 Python#3011
maturin develop on Windows ARM with x86 Python#3011Conversation
Windows ARM can natively run x86_64 binaries, so building for `x86_64-pc-windows-msvc` from `aarch64-pc-windows` should not be treated as cross-compilation. Also extend `detect_arch_from_python` to auto-detect architecture mismatches on Windows (e.g. x86_64 Python on ARM host), so `maturin develop` works without needing `--target`. Fixes PyO3#2778
messense
changed the title
maturin develop on Windows ARM with x86 Python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows ARM can natively run x86_64 binaries, so building for
x86_64-pc-windows-msvcfromaarch64-pc-windowsshould not be treated as cross-compilation.Also extend
detect_arch_from_pythonto auto-detect architecture mismatches on Windows (e.g. x86_64 Python on ARM host), somaturin developworks without needing--target.Fixes #2778