consistent liquid_surface_no_lld kwarg between aspirate and dispense on star #816
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
liquid_surface_no_lld determines the starting position of an aspirate or dispense on a STAR when not using LLD
This PR will break implementations that fixed the string inconsistency using
liquid_surfaces_no_lldas an aspirate kwarg andliquid_surface_no_lldfor dispense on the STAR backend.Ultimately we should decide on
liquid_surfaces_no_lldorliquid_surface_no_lld, and use the same string for both aspiration and dispense. I preferliquid_surface_no_lldbecause this is an exact string match to the firmware documentation.