Add automatic codec selection and header support to binary IO #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce BinaryValueCodecSelector for optimal codec choice based on DoubleDataValue range, sign, and type. Add BinaryValueCodecType enum for stable mapping. Refactor all codecs to use a consistent ByteCount property and update buffer logic for compatibility. Enhance BinaryDataReader to support headerLengthBytes, ensuring correct offset handling for chunked and stream reads. Add comprehensive unit tests for codec selection and header offset logic. Improve robustness and readability of binary IO code.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the binary data IO subsystem by introducing automatic codec selection based on value characteristics and adding header offset support for reading binary data streams. The changes improve memory efficiency through optimal codec selection and enable reading of binary files with metadata headers.
Changes:
- Introduce
BinaryValueCodecSelectorto automatically choose the most compact codec based on value range, sign, and precision requirements - Add
BinaryValueCodecTypeenum for stable codec mapping - Refactor all codec implementations to use consistent
ByteCountas a compile-time constant - Add header offset support to
BinaryDataReaderfor both seekable and non-seekable streams - Add comprehensive unit tests for codec selection logic and header offset handling
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| BinaryValueCodecType.cs | New enum defining all supported codec types with explicit integer values |
| BinaryValueCodecSelector.cs | New class implementing automatic codec selection based on data value analysis |
| BinaryValueCodecBase.cs | Updated to use consistent byteCount parameter naming |
| UInt16Codec.cs | Refactored to use const ByteCount and primary constructor |
| UInt24Codec.cs | Refactored to use const ByteCount |
| UInt32Codec.cs | Refactored to use const ByteCount |
| Int16Codec.cs | Refactored to use const ByteCount and primary constructor |
| Int24Codec.cs | Refactored to use const ByteCount |
| Int32Codec.cs | Refactored to use const ByteCount |
| FloatCodec.cs | Refactored to use const ByteCount |
| DoubleCodec.cs | Refactored to use const ByteCount |
| BinaryDataReader.cs | Added headerLengthBytes parameter and offset calculations for both seekable and non-seekable streams |
| BinaryValueCodecSelectorTests.cs | Comprehensive unit tests for codec selection logic |
| BinaryDataReaderStreamTests.cs | Unit tests validating header offset handling in stream reads |
| BinaryDataReaderChunkTests.cs | Unit tests validating header offset handling in chunked reads |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Tools/Px.Utils into feature/binary-codec-selector
sakari-malkki
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce BinaryValueCodecSelector for optimal codec choice based on DoubleDataValue range, sign, and type. Add BinaryValueCodecType enum for stable mapping. Refactor all codecs to use a consistent ByteCount property and update buffer logic for compatibility. Enhance BinaryDataReader to support headerLengthBytes, ensuring correct offset handling for chunked and stream reads. Add comprehensive unit tests for codec selection and header offset logic. Improve robustness and readability of binary IO code.