Added Schematic and the DS3231.ccp Year fix from arduino Forums just in case#3
Open
Meins321 wants to merge 5 commits intoPuceBaboon:masterfrom
Open
Added Schematic and the DS3231.ccp Year fix from arduino Forums just in case#3Meins321 wants to merge 5 commits intoPuceBaboon:masterfrom
Meins321 wants to merge 5 commits intoPuceBaboon:masterfrom
Conversation
Owner
|
Moritz,
Thank you very much indeed for taking the time to put together this pull
request; I really appreciate it.
Please forgive me, but I don't particularly want to include fixes for
Rodan's library into the codebase in this project (especially as I've moved
away from using that particular library myself). Your pull request did
(finally!) prompt me to update the project, though. I've added in a
schematic which better reflects the actual hardware that has been in use
here for quite a few years, as well as some information on changes to the
DS3231 module itself to reduce current consumption even more.
I will try to update the code to the RTClib version sometime in the very
near future (the ground is frozen solid here still, so work outside has
slowed down a lot).
Again, very many thanks for the time and effort you made putting
together the pull request (your name is now listed in the README as a
contributor).
Best wishes from a cold and snowy Japan,
-John-
…On Wed, 16 Feb 2022 at 18:41, Moritz Mueller ***@***.***> wrote:
Maybe add those two files for others to look into makes this much more
usefull for little "node" building :-p
------------------------------
You can view, comment on, or merge this pull request online at:
#3
Commit Summary
- bade88e
<bade88e>
Add files via upload
- 7b9c776
<7b9c776>
Add files via upload
- 2feabe7
<2feabe7>
DS3231.cpp Year Error Fix from Arduino Forum
- 0e54849
<0e54849>
Delete Circuit.PuceBaboon.ESP8266.DS3231..png
- 88554ee
<88554ee>
Circuit Diagramm as a PNG Picture
File Changes
(2 files <https://github.com/PuceBaboon/ESP8266-DS3231/pull/3/files>)
- *A* Circuit.PuceBaboon.ESP8266.DS3231.png
<https://github.com/PuceBaboon/ESP8266-DS3231/pull/3/files#diff-84033a4beb93ece58010f325a4c942c8994656282a627b8459bafccd24f0fc46>
(0)
- *A* DS3231.cpp.zip
<https://github.com/PuceBaboon/ESP8266-DS3231/pull/3/files#diff-ee3cf902d27d2a5ac12698b63c104d30756cb84ab1807b43a1a8b27f698eb15e>
(0)
Patch Links:
- https://github.com/PuceBaboon/ESP8266-DS3231/pull/3.patch
- https://github.com/PuceBaboon/ESP8266-DS3231/pull/3.diff
—
Reply to this email directly, view it on GitHub
<#3>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACRO2WMY74KZZJOE73FZUKLU3NWMTANCNFSM5ORBYTCA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe add those two files for others to look into makes this much more usefull for little "node" building :-p