UOE-11371: Wakanda Data is not logged if logger is disabled using publisher feature.#942
Open
pm-priyanka-bagade wants to merge 2 commits intocifrom
Open
UOE-11371: Wakanda Data is not logged if logger is disabled using publisher feature.#942pm-priyanka-bagade wants to merge 2 commits intocifrom
pm-priyanka-bagade wants to merge 2 commits intocifrom
Conversation
| *orignalMaxBidResponse = *ao.Response | ||
| } | ||
| var loggerURL string | ||
| var headers http.Header |
Collaborator
There was a problem hiding this comment.
Move var headers http.Header inside the if block.
Pubmatic-Dhruv-Sonone
requested changes
Oct 16, 2024
| } | ||
| var loggerURL string | ||
| var headers http.Header | ||
| if !rCtx.LoggerDisabled { |
Collaborator
There was a problem hiding this comment.
Can you add a UT for following scenarios?
- Logger is Disabled and Wakanda is enabled for AppLovin Endpoint.
- Logger is Disabled and Wakanda is enabled for Some other endpoint Request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.