Skip to content

UOE-12593: Rename strictvastmode to google_ssu_feature in JSON and strictVastMode to googleSSUFeature in DB call #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pubmatic-Supriya-Patil wants to merge 1 commit into
base: ci
Choose a base branch
from
Open

UOE-12593: Rename strictvastmode to google_ssu_feature in JSON and strictVastMode to googleSSUFeature in DB call #1101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions exchange/exchange_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,7 +1064,7 @@ func TestHoldAuction_FilterBidsByVastVersions(t *testing.T) {
},
Test: 1,
Cur: []string{"USD"},
Ext: json.RawMessage(`{"prebid":{"strictvastmode":true}}`),
Ext: json.RawMessage(`{"prebid":{"google_ssu_feature":true}}`),
}},
bidderImpl: &goodSingleBidder{
httpRequest: &adapters.RequestData{
Expand All @@ -1083,7 +1083,7 @@ func TestHoldAuction_FilterBidsByVastVersions(t *testing.T) {
}},
expected: testResults{
bidFloorCur: "USD",
resolvedReq: `{"id":"some-request-id","imp":[{"id":"some-impression-id","bidfloor":15,"bidfloorcur":"USD","ext":{"prebid":{"bidder":{"appnexus":{"placementId":1}}}}}],"site":{"domain":"www.website.com","page":"prebid.org","ext":{"amp":0}},"test":1,"cur":["USD"],"ext":{"prebid":{"strictvastmode":true}}}`,
resolvedReq: `{"id":"some-request-id","imp":[{"id":"some-impression-id","bidfloor":15,"bidfloorcur":"USD","ext":{"prebid":{"bidder":{"appnexus":{"placementId":1}}}}}],"site":{"domain":"www.website.com","page":"prebid.org","ext":{"amp":0}},"test":1,"cur":["USD"],"ext":{"prebid":{"google_ssu_feature":true}}}`,
},
},
{
Expand All @@ -1103,7 +1103,7 @@ func TestHoldAuction_FilterBidsByVastVersions(t *testing.T) {
},
Test: 1,
Cur: []string{"USD"},
Ext: json.RawMessage(`{"prebid":{"strictvastmode":true}}`),
Ext: json.RawMessage(`{"prebid":{"google_ssu_feature":true}}`),
}},
bidderImpl: &goodSingleBidder{
httpRequest: &adapters.RequestData{
Expand All @@ -1122,7 +1122,7 @@ func TestHoldAuction_FilterBidsByVastVersions(t *testing.T) {
}},
expected: testResults{
bidFloorCur: "USD",
resolvedReq: `{"id":"some-request-id","imp":[{"id":"some-impression-id","bidfloor":15,"bidfloorcur":"USD","ext":{"prebid":{"bidder":{"appnexus":{"placementId":1}}}}}],"site":{"domain":"www.website.com","page":"prebid.org","ext":{"amp":0}},"test":1,"cur":["USD"],"ext":{"prebid":{"strictvastmode":true}}}`,
resolvedReq: `{"id":"some-request-id","imp":[{"id":"some-impression-id","bidfloor":15,"bidfloorcur":"USD","ext":{"prebid":{"bidder":{"appnexus":{"placementId":1}}}}}],"site":{"domain":"www.website.com","page":"prebid.org","ext":{"amp":0}},"test":1,"cur":["USD"],"ext":{"prebid":{"google_ssu_feature":true}}}`,
errMessage: "appnexus Bid some-bid-id was filtered for Imp with Vast Version 2.0: Incompatible with GAM unwinding requirements",
errCode: 10014,
},
Expand Down
10 changes: 5 additions & 5 deletions modules/pubmatic/openwrap/beforevalidationhook_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2058,7 +2058,7 @@ func TestOpenWrapApplyProfileChanges(t *testing.T) {
Language: "en",
},
},
Ext: json.RawMessage(`{"prebid":{"strictvastmode":true}}`),
Ext: json.RawMessage(`{"prebid":{"google_ssu_feature":true}}`),
},
wantErr: false,
},
Expand Down Expand Up @@ -2176,7 +2176,7 @@ func TestOpenWrapApplyProfileChanges(t *testing.T) {
Language: "en",
},
},
Ext: json.RawMessage(`{"prebid":{"strictvastmode":true}}`),
Ext: json.RawMessage(`{"prebid":{"google_ssu_feature":true}}`),
},
wantErr: false,
},
Expand Down Expand Up @@ -2276,7 +2276,7 @@ func TestOpenWrapApplyProfileChanges(t *testing.T) {
Language: "en",
},
},
Ext: json.RawMessage(`{"prebid":{"strictvastmode":true}}`),
Ext: json.RawMessage(`{"prebid":{"google_ssu_feature":true}}`),
},
wantErr: false,
},
Expand Down Expand Up @@ -2375,7 +2375,7 @@ func TestOpenWrapApplyProfileChanges(t *testing.T) {
Language: "en",
},
},
Ext: json.RawMessage(`{"prebid":{"strictvastmode":true}}`),
Ext: json.RawMessage(`{"prebid":{"google_ssu_feature":true}}`),
},
wantErr: false,
},
Expand Down Expand Up @@ -2604,7 +2604,7 @@ func TestOpenWrap_applyImpVideoChanges(t *testing.T) {
expectedVideo *openrtb2.Video
}{
{
name: "strictvastmode_enabled",
name: "google_ssu_feature_enabled",
inputVideo: &openrtb2.Video{
Protocols: []adcom1.MediaCreativeSubtype{
adcom1.CreativeVAST10,
Expand Down
2 changes: 1 addition & 1 deletion modules/pubmatic/openwrap/models/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const (
PLATFORM_KEY = "platform"
SendAllBidsKey = "sendAllBids"
VastUnwrapperEnableKey = "enableVastUnwrapper"
GoogleSSUFeatureEnabledKey = "strictVastMode"
GoogleSSUFeatureEnabledKey = "googleSSUFeature"
VastUnwrapTrafficPercentKey = "vastUnwrapTrafficPercent"
SSTimeoutKey = "ssTimeout"
PWC = "awc"
Expand Down
2 changes: 1 addition & 1 deletion openrtb_ext/openwrap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ type ExtOWRequestPrebid struct {
Transparency *TransparencyExt `json:"transparency,omitempty"`
KeyVal map[string]interface{} `json:"keyval,omitempty"`
TrackerDisabled bool `json:"tracker_disabled,omitempty"`
GoogleSSUFeatureEnabled bool `json:"strictvastmode,omitempty"`
GoogleSSUFeatureEnabled bool `json:"google_ssu_feature,omitempty"`
DebugOverride bool `json:"debug_override,omitempty"`
}

Expand Down
Loading