Conversation
|
Hi @IAvecilla, i saw this comment: #506 (comment) |
| } | ||
| Err(err) => { | ||
| println!( | ||
| "Failed to load with local data provider. {err:?} Trying preprocessed data provider instead" |
There was a problem hiding this comment.
in main, the train.rs falls back to pre-processed data if local data fails, this change keeps this behaviour, but might be more clear if it has an explicit option.
There was a problem hiding this comment.
Yeah, I think it’s a good idea to separate the possibility of using Preprocessed data. We might even end up splitting it further into Preprocessed Local (this behavior) and HTTP Preprocessed, which is the one I mentioned in the issue and whose implementation is here: #506. That should cover all the different data provider possibilities we have at the moment.
|
Hey sorry for the delay! I've tested some cases and it seems to be working alright, good PR. I was wondering that now since we have a more options for the tool, if the user gives no arguments it should show the --help text to let them know what is available So instead of Perhaps show I think we can do it with something like if !std::path::Path::new(data_path).exists() {
eprintln!("Error: Data directory '{}' does not exist.\n", data_path);
CliArgs::command().print_long_help()?;
std::process::exit(1);
} |
Merges the HTTP example with the train example