Skip to content

Conversation

@dexter2206
Copy link
Contributor

Description

We accidentally introduced a performance regression in this commit. This keeps the functionality, but reverses performance impact.

Please verify that you have completed the following steps

  • I have self-reviewed my code.
  • I have included test cases validating introduced feature/fix.
  • I have updated documentation.

@cla-bot
Copy link

cla-bot bot commented Nov 3, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Konrad Jałowiecki.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@dexter2206 dexter2206 changed the title fix: Fix performance regression caused by inefficient looping fix: fix performance regression caused by inefficient looping Nov 3, 2025
@dexter2206 dexter2206 force-pushed the kj/fix-perf-regression branch from 3e0fc05 to a2198f1 Compare November 3, 2025 13:40
@cla-bot cla-bot bot added the cla-signed label Nov 3, 2025
@dexter2206 dexter2206 force-pushed the kj/fix-perf-regression branch from a2198f1 to f7aea41 Compare November 3, 2025 13:55
Copy link
Contributor

@Brendan-Reid1991 Brendan-Reid1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, no notes!

@dexter2206 dexter2206 merged commit ac65b80 into main Nov 3, 2025
9 checks passed
@dexter2206 dexter2206 deleted the kj/fix-perf-regression branch November 3, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants