Skip to content

Conversation

@SignatureBeef
Copy link
Member

@SignatureBeef SignatureBeef commented Jan 3, 2025

This PR aims for the following:

  • Target frameworks & workflows updated to net9.0
  • OTAPI and other packages updated
  • Moved to generated OTAPI static hooks, making MonoMod RD optional/supplemental (though, OTAPI.Runtime.dll is still included for those still utilising it, and works on net9)
    • Note: File scoped namespaces was utilised, which is why the diff is more than expected.
  • Expanded workflow to test each platform
  • Reduced OTAPI/ModFw console outputs (e.g. no tile ctor print, short version codes etc)

Considerations that may flow through to a TShock PR (or sooner if desired):

  • OTAPI Static Hook namespace naming preferences e.g. HookEvents.* vs MonoMod RD On.*
  • OTAPI Static Hook EventArgs property naming preferences e.g. ContinueExecution, HookReturnValue
  • If any extra static hooks are needed, current list includes most methods from the following Terraria types:
    • Main, Item, NetMessage, Netplay, NPC, WorldGen, Chat.ChatHelper, IO.WorldFile, Net.NetManager, Projectile, RemoteClient, Liquid, Program.
  • Apple Silicon / ARM64 testing
  • Plugin updates: at the moment should just be a matter of ticking up to net9.0, and matching dependencies/updating

Screenshots

Windows x64

image
image

MacOS Arm64

image image Joining Mac Arm64 from Win64:

image

@SignatureBeef SignatureBeef requested a review from QuiCM January 3, 2025 14:06
@SignatureBeef SignatureBeef self-assigned this Jan 3, 2025
Copy link
Contributor

@Arthri Arthri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested the changes in game, however, the code changes look good. Thank you for working on this

@QuiCM
Copy link
Member

QuiCM commented Jan 8, 2025

I too have not tested in game, but LGTM

@hakusaro
Copy link
Member

@SignatureBeef I merged #253, can you rebase?

@hakusaro hakusaro merged commit 2c82f67 into Pryaxis:general-devel Jan 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants