Skip to content

fix: cache handling in SmashConfig due to invalid path exception #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidberenstein1957 merged 3 commits into from
Apr 2, 2026
+9 −3
Merged

fix: cache handling in SmashConfig due to invalid path exception #598

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
325846b
update path handling of cache to fix smash config crash.
ParagEkbote Mar 26, 2026
4020fce
update to fix linting errors.
ParagEkbote Mar 26, 2026
09933a2
update to make self.cache_dir handle more types and more robust
ParagEkbote Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/pruna/config/smash_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def __init__(
self.cache_dir_prefix = Path(cache_dir_prefix)
if not self.cache_dir_prefix.exists():
self.cache_dir_prefix.mkdir(parents=True, exist_ok=True)
self.cache_dir = Path(tempfile.mkdtemp(dir=cache_dir_prefix))
self.cache_dir = Path(tempfile.mkdtemp(dir=self.cache_dir_prefix))

self.save_fns: list[str] = []
self.load_fns: list[str] = []
Expand Down Expand Up @@ -217,8 +217,14 @@ def __eq__(self, other: Any) -> bool:

def cleanup_cache_dir(self) -> None:
"""Clean up the cache directory."""
if self.cache_dir.exists():
shutil.rmtree(self.cache_dir)
if hasattr(self, "cache_dir") and self.cache_dir is not None:
cache_path = Path(self.cache_dir)

if not isinstance(cache_path, Path):
raise TypeError(f"cache_dir must be path-like, got {type(self.cache_dir)}")

if cache_path.exists() and cache_path.is_dir():
shutil.rmtree(cache_path, ignore_errors=True)

def reset_cache_dir(self) -> None:
"""Reset the cache directory."""
Expand Down
Loading