Replace firstChild with firstElementChild#248
Open
raftx24 wants to merge 1 commit intoProseMirror:masterfrom
Open
Replace firstChild with firstElementChild#248raftx24 wants to merge 1 commit intoProseMirror:masterfrom
raftx24 wants to merge 1 commit intoProseMirror:masterfrom
Conversation
Issue: In certain cases, firstChild returns a textNode due to whitespace or other content. This causes the resize functionality to break, as it expects an element node. Solution: To resolve this, I've replaced firstChild with firstElementChild. This ensures that the resize logic always interacts with a valid element node, preventing breaks in cases where firstChild returns a textNode.
Collaborator
|
Could you provide a minimal reproduction for "In certain cases, firstChild returns a textNode due to whitespace or other content"? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
In certain cases,
firstChildreturns a textNode due to whitespace or other content. This causes the resize functionality to break, as it expects an element node.Solution:
To resolve this, I've replaced
firstChildwithfirstElementChild. This ensures that the resize logic always interacts with a valid element node, preventing breaks in cases where firstChild returns a textNode.issue in tiptap: ueberdosis/tiptap#5695