fixed nodesBetween when child is undefinded bug

[XuXuDev]

I came across a situation where the child node is undefined.

[marijnh]

Could it be that something was calling the method with a to bigger than the node's content size? Because that's the only way it seems this will happen, and that's an error on the caller side, so I'd rather not paper it over by adding null checks here.

[XuXuDev]

My problem is this： i want use rangeHasMark function but this Happening error on nodesBetween

[marijnh]

I think the problem is that the positions that rangeHasMark expects are local to the node, and you're passing document-level positions. I.e. .rangeHasMark(0, node.content.size, ...) will probably work better.

[XuXuDev]

I took your advice, but I still have problems.

[hubgit]

Could ProseMirror perhaps output a different error message if the to value is larger than the node's content size?

[marijnh]

Raising an explicit error would be fine by me. Do you want to create a pull request?

[anarchang]

I have also run into the bug in two separate instances. One of the cases is when trying to remove more than one row or column in a table. I had a slightly different solution but I think either would work. My solution adds an extra end case to the for loop:

    for (let i = 0, pos = 0; pos < to && i < this.content.length; i++) {

I am happy to create a PR if you would like to see a different solution.

[marijnh]

@anarchang I'm not sure which code that line is from, and what problem you're addressing.

[davidstrouk]

@marijnh could we merge this PR? It would be useful to raise an explicit error when child is undefined. I don't mind opening a new PR if you think this one is already old.

[marijnh]

No. I don't want to paper over stuff that's going wrong elsewhere by silently ignoring it here.

[davidstrouk]

Ok, I understand. Could we at least raise an exception so that we can catch it elsewhere? TypeError seems to broad in order to catch it.

I know it was a while ago, but you wrote

Raising an explicit error would be fine by me.