Setup Submariner and Karmada integration#89
Conversation
- Added `argocd-karmada-endpoint` app to `apps.yaml` to register Karmada as an ArgoCD cluster. - Enabled `argocd-karmada-endpoint` in `clusters/cc.yaml` (Control Cluster). - Created helper script `scripts/sync-secrets.py` to sync Submariner broker info and Karmada admin config from clusters to Vault. - Updated `pulumi/__main__.py` to support `labels` and `annotations` in `vaultSecrets` destination configuration, enabling correct labeling of the ArgoCD cluster secret. Co-authored-by: ProjectInitiative <6314611+ProjectInitiative@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Updated `.github/workflows/manifest-diff.yaml`, `.github/workflows/build-push-nixos-remote-builder.yaml`, and `.github/workflows/build-push-pulumi-cmp.yaml` to use `DeterminateSystems/nix-installer-action@v16`. - This resolves the "TypeError: Invalid URL" error caused by deprecated Node.js versions in the older v10 action. Co-authored-by: ProjectInitiative <6314611+ProjectInitiative@users.noreply.github.com>
- Updated `nix/scripts/generate-manifests.nix` to include `${pkgs.pulumi}/bin` in `PATH`.
- This ensures the Nix-bundled `pulumi-language-python` is used instead of the incompatible pre-installed version on GitHub Actions runners, resolving the "flag provided but not defined: -root" error.
Co-authored-by: ProjectInitiative <6314611+ProjectInitiative@users.noreply.github.com>
- Updated `nix/scripts/generate-manifests.nix` to include `${pkgs.pulumi}/bin` in `PATH`.
- This ensures the Nix-bundled `pulumi-language-python` is used instead of the incompatible pre-installed version on GitHub Actions runners, resolving the "flag provided but not defined: -root" error.
Co-authored-by: ProjectInitiative <6314611+ProjectInitiative@users.noreply.github.com>
Manifest Changes DetectedClick to expand diffOnly in manifests-pr/1-manifest: argoproj.io_v1alpha1-application-argocd-cc-argocd-karmada-endpoint.yaml
|
1 participant
This PR addresses the user request to setup Submariner and add Karmada as an ArgoCD endpoint.
Changes:
Helper Script (
scripts/sync-secrets.py):cc) and writes it to Vault pathsubmariner/broker-info.cc, formats it as an ArgoCD cluster config (JSON), and writes it to Vault pathkarmada/config.ArgoCD Karmada Endpoint (
apps/base/argocd-karmada-endpoint):argocdnamespace.vaultSecretsto pull the config from Vault.Pulumi Update (
pulumi/__main__.py):vaultSecretshandling to supportlabelsandannotationson the destination secret.argocd.argoproj.io/secret-type: clusterlabel automatically via VSO.Cluster Configuration (
clusters/cc.yaml):argocd-karmada-endpointon the Control Cluster (cc).Verification:
pulumi/__main__.pychanges correctly map config labels to the generated manifest structure.PR created automatically by Jules for task 3015386288140939478 started by @ProjectInitiative