fix LTASDataset sft serialization #318
Merged
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieudpnt
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small fix for LTASDataset serialization/deserialization:
When I added the
embed_sftparameter to theSpectroData.to_dict()method, I apparently forgot to use it in theLTASData(en thenLTASDataset) serialization.The aim is to export each sft only once (since I can't serialize the window without exporting every value, it makes quite large JSONs if one SFT is serialized per Data object), with a ref within the serialized sft towards each associated SpectroData (or LTASData).
it should fix #285 too, as now the LTASData are properly deserialized when the sft is specified as parameter.