ScalePart value checking #317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just found a bug with @PaulCarvaillo @PCarvaillo, where computing a spectrogram with a Scale that has incorrect parameters (e.g. a
ScalePartwithp_max = 100) would lead to a huuuuuuuuge explosion in RAM usage.This PR prevents the user from instantiating
ScalePartinstances with incorrect values. The enforced conditions are:p_min >= 0p_max >= 0p_min <= 1p_max <= 1p_min < p_maxf_min >= 0f_max >= 0f_min < f_maxWith these checks in
ScalePart.__post_init__(), there should be no way of reproducing the RAM explosion experienced before.