-
Notifications
You must be signed in to change notification settings - Fork 470
docs: add docs for using ascend device in volcano #1488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: james <open4pd@4paradigm.com>
Summary of ChangesHello @DSFans2014, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands Volcano's documentation by introducing a comprehensive guide for leveraging Huawei Ascend devices, specifically the 310 and 910 series, within a Volcano-managed Kubernetes cluster. It covers the entire setup process, from prerequisites and installation of necessary plugins to detailed scheduler configuration for vNPU and heterogeneous Ascend environments. Additionally, it includes minor formatting improvements and adds Chinese translations for both the new Ascend guide and the existing vGPU guide, making the documentation more robust and accessible. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces documentation for using Ascend devices with Volcano, providing both English and Chinese guides. It also adds a Chinese translation for the vGPU documentation and improves formatting in the existing English vGPU guide. The changes are a valuable addition. My review includes several minor suggestions to enhance the clarity, grammar, and formatting of the new documentation files.
Signed-off-by: james <open4pd@4paradigm.com>
Signed-off-by: james <open4pd@4paradigm.com>
|
This repo is not related to volcano, you can submit to hami-website here |
the docs in |
Signed-off-by: james <open4pd@4paradigm.com>
archlitchi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: archlitchi, DSFans2014 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* docs: add docs for using ascend device in volcano Signed-off-by: james <open4pd@4paradigm.com> * fix: fix the comment Signed-off-by: james <open4pd@4paradigm.com> * fix: fix comment Signed-off-by: james <open4pd@4paradigm.com> * docs: update docs Signed-off-by: james <open4pd@4paradigm.com> --------- Signed-off-by: james <open4pd@4paradigm.com>
the relevant pr is volcano-sh/volcano#4717