Skip to content

Conversation

@DSFans2014
Copy link
Contributor

@DSFans2014 DSFans2014 commented Nov 11, 2025

the relevant pr is volcano-sh/volcano#4717

Signed-off-by: james <open4pd@4paradigm.com>
@hami-robot hami-robot bot requested review from FouoF and wawa0210 November 11, 2025 09:51
@github-actions github-actions bot added the kind/documentation Improvements or additions to documentation label Nov 11, 2025
@hami-robot hami-robot bot added the size/L label Nov 11, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @DSFans2014, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands Volcano's documentation by introducing a comprehensive guide for leveraging Huawei Ascend devices, specifically the 310 and 910 series, within a Volcano-managed Kubernetes cluster. It covers the entire setup process, from prerequisites and installation of necessary plugins to detailed scheduler configuration for vNPU and heterogeneous Ascend environments. Additionally, it includes minor formatting improvements and adds Chinese translations for both the new Ascend guide and the existing vGPU guide, making the documentation more robust and accessible.

Highlights

  • Ascend Device Documentation: New documentation has been added to guide users on integrating Huawei Ascend 310 and 910 devices with Volcano, supporting vNPU and heterogeneous cluster configurations.
  • Scheduler Configuration: Detailed steps are provided for configuring the Volcano scheduler to enable Ascend vNPU functionality, including specific ConfigMap arguments.
  • vGPU Documentation Update: The existing vGPU documentation has been slightly refined to improve the formatting of installation commands and add a link to more installation methods.
  • Multilingual Support: Chinese versions of both the new Ascend device guide and the existing vGPU guide have been added, enhancing accessibility for a broader audience.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces documentation for using Ascend devices with Volcano, providing both English and Chinese guides. It also adds a Chinese translation for the vGPU documentation and improves formatting in the existing English vGPU guide. The changes are a valuable addition. My review includes several minor suggestions to enhance the clarity, grammar, and formatting of the new documentation files.

Signed-off-by: james <open4pd@4paradigm.com>
Signed-off-by: james <open4pd@4paradigm.com>
@archlitchi
Copy link
Member

This repo is not related to volcano, you can submit to hami-website here
https://github.com/Project-HAMi/website

@DSFans2014
Copy link
Contributor Author

This repo is not related to volcano, you can submit to hami-website here
https://github.com/Project-HAMi/website

the docs in website can be found here Project-HAMi/website#114

Copy link
Member

@archlitchi archlitchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hami-robot
Copy link
Contributor

hami-robot bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi, DSFans2014

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot hami-robot bot added the approved label Nov 17, 2025
@hami-robot hami-robot bot merged commit d4942e9 into Project-HAMi:master Nov 17, 2025
14 checks passed
DSFans2014 referenced this pull request in DSFans2014/HAMi-bak Jan 20, 2026
* docs: add docs for using ascend device in volcano

Signed-off-by: james <open4pd@4paradigm.com>

* fix: fix the comment

Signed-off-by: james <open4pd@4paradigm.com>

* fix: fix comment

Signed-off-by: james <open4pd@4paradigm.com>

* docs: update docs

Signed-off-by: james <open4pd@4paradigm.com>

---------

Signed-off-by: james <open4pd@4paradigm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants