Full codebase for review #62
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laviRZ
commented
Jan 8, 2026
Comment on lines
+116
to
+119
| final BaseStatusSignal[] newSignals = new BaseStatusSignal[RIO_SIGNALS.length + 1]; | ||
| System.arraycopy(RIO_SIGNALS, 0, newSignals, 0, RIO_SIGNALS.length); | ||
| newSignals[RIO_SIGNALS.length] = statusSignal; | ||
| RIO_SIGNALS = newSignals; |
Author
There was a problem hiding this comment.
Why not make RIO_SIGNALS an ArrayList so it has a dynamic size, and wherever needed convert it to a regular array?
If performance matters, it's possible to cache the result of the conversion
Member
There was a problem hiding this comment.
Not sure I fully understand you. Caching seems more wasteful at runtime
laviRZ
commented
Jan 8, 2026
|
|
||
| @Override | ||
| public void toLog(LogTable table) { | ||
| if (numberOfInputs == 0 && signalToThreadedQueue.isEmpty()) |
laviRZ
commented
Jan 8, 2026
| } | ||
|
|
||
| private void updateSignalsToTable(LogTable table) { | ||
| if (firstInputIndex == -1 || numberOfInputs == 0) |
Author
There was a problem hiding this comment.
it's enough to check for firstInputIndex == -1, because it has to be true when numberOfInputs == 0
Member
There was a problem hiding this comment.
Is there a reason not to check both? Seems safer/more scaleable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.