Climber

[ShmayaR]

No description provided.

[coderabbitai]

Walkthrough

Adds a new Climber subsystem package frc.trigon.robot.subsystems.climber with Climber, ClimberCommands, and ClimberConstants (motor configuration, simulation, visualization, and nested ClimberState enum). Adds ClimbCommands factory for climb sequences. Exposes a new public static CLIMBER field in RobotContainer and expands imports for climber/shooter/swerve. Adjusts motor IDs: HoodConstants.MOTOR_ID 18→17; ShooterConstants.MASTER_MOTOR_ID 16→15 and FOLLOWER_MOTOR_ID 17→16.

🚥 Pre-merge checks | ❌ 3

❌ Failed checks (1 warning, 2 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Climber' is vague and generic, using a single word that doesn't convey meaningful information about what was actually implemented or changed.	Use a more descriptive title like 'Add Climber subsystem with commands and constants' to clarify the scope of changes.
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess whether the intent aligns with the changeset.	Add a description explaining the purpose of the Climber subsystem, how it integrates with existing systems, and any configuration changes to motor IDs.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 5

[coderabbitai]

Actionable comments posted: 3

♻️ Duplicate comments (1)

src/main/java/frc/trigon/robot/subsystems/climber/Climber.java (1)

41-44: stop() should reset targetState.

Based on learnings, all subsystem stop() methods should reset relevant target fields. Add targetState = ClimberConstants.ClimberState.REST; after stopping the motor.

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (1)

src/main/java/frc/trigon/robot/subsystems/climber/Climber.java (1)

41-44: Reset targetState on stop to avoid stale targets.
Line 42 stops the motor but preserves targetState. For subsystems in this repo, stop() is expected to clear target fields to prevent stale state across stop/start cycles. Consider resetting to ClimberConstants.ClimberState.REST (or confirm that preserving is intentional for this mechanism). Based on learnings, ...

[Strflightmight09]

Look at how climbing was done for Larry and Killshon and implement that stuff here instead of what you have now

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Actionable comments posted: 3

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Actionable comments posted: 2

[coderabbitai]

Actionable comments posted: 2

[coderabbitai]

Actionable comments posted: 1

[Nummun14]

Fixy