-
Notifications
You must be signed in to change notification settings - Fork 6
Regex_Search: Add tokenizer, postfix conversion, and NFA construction #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert accidental formatting changes Revert accidental formatting changes in exact module Final fixes l
AviShahCode
reviewed
Jan 26, 2026
AviShahCode
reviewed
Jan 26, 2026
AviShahCode
reviewed
Jan 26, 2026
AviShahCode
reviewed
Jan 26, 2026
Ovetsarilish
requested changes
Jan 30, 2026
Ovetsarilish
approved these changes
Jan 30, 2026
…at_tokens() std::move in add_concat_tokens() in RegexTokenizer.cpp
Ovetsarilish
requested changes
Jan 31, 2026
Member
Ovetsarilish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the match method which the user uses as an API seems to be missing. Is the code for that done? Make sure that the match can find multiple instances of the pattern in sample text.
I am struggling to visualize the save_id part, once that is clear will review the rest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds regex tokenizer with support for:
Adds infix → postfix (RPN) conversion for regex tokens:
Adds ε-NFA core representation (Nfa.hpp) and Thompson-style NFA construction (NfaBuilder.hpp):
This is a draft for review.