Conversation
GiooDev
added
bug
Collaborator
|
New Issues (5)Checkmarx found the following issues in this Pull Request
Fixed Issues (246)Great job! The following issues were fixed in this Pull Request
Use @Checkmarx to interact with Checkmarx PR Assistant. |
GiooDev
force-pushed
the
bug_15751
branch
2 times, most recently
from
6b81c00 to
cd90d4a
Compare
marob
approved these changes
Feb 25, 2026
Contributor
There was a problem hiding this comment.
C'est lié aux caractères spéciaux du mot de passe ?
Et je ne vois pas de modification de code pour le décoder (b64decode) au moment où on en a besoin.
Contributor
Author
There was a problem hiding this comment.
Ouep exactement, c'est pour "gérer" les caractères spéciaux si un utilisateur souhaite en définir car le format attendu de ce fichier est du base64.
Contributor
There was a problem hiding this comment.
Mais avant c'était pas en base64 ?
Contributor
There was a problem hiding this comment.
OK, les caractères autorisés sont restreints. Donc pour laisser la possibilité de choisir n'importe quel caractère, tu décides finalement de ne pas mettre le mot de passe renseigné, mais sa version base64 ?
Mais du coup, impact sur les install existantes ?
Contributor
Author
There was a problem hiding this comment.
Nop avant c'était pas en base64 mais on limitait les caractères à du alphanumérique sans caractères spéciaux.
Normalement en cas de montée de réapplication sur une installation existante, on va venir mettre à jour le fichier sur l'ensemble des machines donc ça devrait passer.
Mais tu as raison, ça fait parti des points que je m'étais noté dans un coin à contre-tester. Je le note dans le ticket pour pas l'oublier.
Contributor
Author
There was a problem hiding this comment.
Bon ça semble pas si simple, je la passe en Draft le temps de trouver une solution adéquate ;)
GiooDev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://www.mongodb.com/docs/manual/reference/connection-string-options/?deployment-type=atlas&interface-atlas-only=atlas-cli#authentication-options
Type de changement
Contributeur