Open
Conversation
Collaborator
|
New Issues (67)Checkmarx found the following issues in this Pull Request
Fixed Issues (83)Great job! The following issues were fixed in this Pull Request
Use @Checkmarx to interact with Checkmarx PR Assistant. |
913c13d to
4f8e575
Compare
c6ebb8d to
0f3f935
Compare
bbenaissa
reviewed
Feb 10, 2026
...i-iam/iam-commons/src/main/java/fr/gouv/vitamui/iam/common/utils/IdentityProviderHelper.java
Show resolved
Hide resolved
api/api-iam/iam-commons/src/main/java/fr/gouv/vitamui/iam/common/utils/Pac4jClientBuilder.java
Outdated
Show resolved
Hide resolved
...iam/iam-commons/src/test/java/fr/gouv/vitamui/iam/common/utils/CustomTokenValidatorTest.java
Outdated
Show resolved
Hide resolved
...i-iam/iam-commons/src/test/java/fr/gouv/vitamui/iam/common/utils/Pac4jClientBuilderTest.java
Outdated
Show resolved
Hide resolved
...s-server/src/main/java/fr/gouv/vitamui/cas/authentication/LoginPwdAuthenticationHandler.java
Outdated
Show resolved
Hide resolved
cas/cas-server/src/main/java/fr/gouv/vitamui/cas/authentication/UserPrincipalResolver.java
Outdated
Show resolved
Hide resolved
cas/cas-server/src/main/java/fr/gouv/vitamui/cas/authentication/UserPrincipalResolver.java
Outdated
Show resolved
Hide resolved
cas/cas-server/src/main/java/fr/gouv/vitamui/cas/authentication/UserPrincipalResolver.java
Outdated
Show resolved
Hide resolved
| return authUser.getProfileGroup() != null; | ||
| } | ||
|
|
||
| private void addAuthenticatedUserAttributes(AuthUserDto authUser, Map<String, List<Object>> attributes) { |
Collaborator
There was a problem hiding this comment.
Est ce normal que ce traitement est fait coté CAS et pas dans IAM?!
Contributor
Author
There was a problem hiding this comment.
Je ne sais pas. Cependant, ici on fait un login IAM pour obtenir les informations pour construire un Principal dans CAS.
lotfivitam
reviewed
Feb 12, 2026
Comment on lines
340
to
360
| # FIXME: Only for testing purpose. Should setup parametrization ? | ||
|
|
||
| cas.authn: | ||
| oauth.session-replication.cookie.crypto: | ||
| encryption.key: Fd-b-pjoN82hBdUti9HqzJXgvfs7pFtVYeaKIRhDdNE | ||
| signing.key: EsCugv7mIHZ3ecx-A5nf_75KsrmVGAWNMXwyEPXDV1jf0nmLrpu0Py6aO62yx4yd_W9_6nhMaGxhE9FQoeP7HQ | ||
| pac4j.core.session-replication.cookie: | ||
| name: DISSESSIONAD | ||
| crypto: | ||
| encryption.key: 9XnxhG7lfRQS9I5_86j3XQHZc19jZsamU97pDtut__o | ||
| signing.key: oFaBMTNLfKgCyqJPjxvZbdFhmxBKFgJP2_-rMDatBN91ZlU3eIpq2SYD_5ILHBSa616VEe5c0yUpACWne6TIlg | ||
| passwordless.tokens.crypto: | ||
| encryption.key: Bo_9H0xCT220Ogn4hvyrbH-x7j5hTAMcs3M8PdDiJ7w | ||
| signing.key: b_ZI3StT4vGnTrWIG4e7fdwNzbgQGN9IsqVo29HLqtstClu1ekzQ_d67K6wtQJLQPSU-RVCF31HuB2OfDkq0mA | ||
| pm.reset.crypto: | ||
| encryption.key: IG2rGK-5ctqoSWMv52XkZZ9BoMqRBcpjdzwLGJ6yiN0 | ||
| signing.key: xPVQOgj1-ywI-O_5fv5pTkg_bBS6CCXh7Yr9zMQoy2bmCjAJfLoVfycKYw-gERmBDozEGeT72HquVOT1dAZO5Q | ||
|
|
||
| cas.webflow.crypto.signing.key: =oebPIRe18A0cAeBdZCHkVlLPa_Kbthxo70iRpAhbk84dQGQj_8AOEMvEg3y7GAKYxtpF5nn6nx7vj5iU-eHStg | ||
| cas.webflow.crypto.encryption.key: 3FzNquczUjhmeJyqu251Ow | ||
| cas.webflow.crypto.encryption.key-size: 128 |
Contributor
Author
There was a problem hiding this comment.
J'ai ajouté la possibilité de configurer.
...api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/customer/config/CustomerInitConfig.java
Show resolved
Hide resolved
cas/cas-server/src/main/java/fr/gouv/vitamui/cas/util/Constants.java
Outdated
Show resolved
Hide resolved
Comment on lines
+803
to
+815
| <plugin> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>${maven.compiler.plugin.version}</version> | ||
| <configuration> | ||
| <annotationProcessorPaths> | ||
| <path> | ||
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> | ||
| <version>${lombok.version}</version> | ||
| </path> | ||
| </annotationProcessorPaths> | ||
| </configuration> | ||
| </plugin> |
lotfivitam
reviewed
Feb 14, 2026
Contributor
lotfivitam
left a comment
There was a problem hiding this comment.
Tout d'abord, bravo pour le taf colossal !
Quelques remarques cependant :
- Pas sûr de comprendre l'usage du "passwordless" vs loginform standard, et lequel est utilisé par lequel (côté WebFlow mais aussi écrans). J'ai essayé de générer un diagramme de séquence représentant le WebFlow de login, mais ça s'avère extrêmement complexe à analyser.
- Il reste un bon coup de cleaup général (cf commentaires de review)
- Prévoir une recette complète des cas avancés (reset de password suite à expiration, reset suite à perte, création de comptes, subrogation user générique, subrogation user nominatif, comptes bloqués, mfa...)
...erver/src/main/java/fr/gouv/vitamui/cas/passwordless/CustomPasswordlessUserAccountStore.java
Outdated
Show resolved
Hide resolved
...va/fr/gouv/vitamui/cas/passwordless/CustomVerifyPasswordlessAccountAuthenticationAction.java
Outdated
Show resolved
Hide resolved
...va/fr/gouv/vitamui/cas/passwordless/CustomVerifyPasswordlessAccountAuthenticationAction.java
Outdated
Show resolved
Hide resolved
cas/cas-server/src/main/resources/templates/passwordless/casPasswordlessGetUserIdView.html
Outdated
Show resolved
Hide resolved
...erver/src/main/java/fr/gouv/vitamui/cas/passwordless/CustomPasswordlessUserAccountStore.java
Outdated
Show resolved
Hide resolved
cas/cas-server/src/main/java/fr/gouv/vitamui/cas/config/WebflowConfig.java
Outdated
Show resolved
Hide resolved
cas/cas-server/src/main/java/fr/gouv/vitamui/cas/config/AppConfig.java
Outdated
Show resolved
Hide resolved
cas/cas-server/src/main/java/fr/gouv/vitamui/cas/config/AppConfig.java
Outdated
Show resolved
Hide resolved
cas/cas-server/src/main/java/fr/gouv/vitamui/cas/config/AppConfig.java
Outdated
Show resolved
Hide resolved
cas/cas-server/src/main/java/fr/gouv/vitamui/cas/config/WebflowConfig.java
Outdated
Show resolved
Hide resolved
a06ca5d to
1932f5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





No description provided.