fix(plant-seeds) #96
Merged
fix(plant-seeds) #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the `request_distributions` schema to replace the `area` with `positions_on_bench` and `dimensions`. Updated related blueprints, tests, and fixtures to accommodate this change. Enhanced validation checks within the `RequestDistribution` model for dimensions and positions attributes to ensure correctness. Simplified routes by adjusting the `request_distributions` index action.
The `invalid_distribution` translation key was removed from both French and English locale files as it is no longer needed. This simplifies the localization files by eliminating unused entries.
…_than_bench_area`. Moved `dimensions` initialization outside the loop block to avoid redundant calls.
Extract validation logic for dimensions into a new `ValidateDimensionsConcern` module to enforce DRY principles. Updated `Bench` and `RequestDistribution` models to include the concern and adjusted related test cases accordingly. Localized error messages have also been updated for consistency.
Extract position validation logic into `ValidatePositionsConcern` for reusability and consistency. Updated relevant models, tests, and locale files to accommodate the shared validation module.
MisterOryon
force-pushed
the
feat/plant-seeds-v2
branch
from
258b68f to
68d71c0
Compare
|
Romain-Lecleire
approved these changes
Jan 8, 2025
Tao-Galasse
reviewed
Jan 13, 2025
Member
Tao-Galasse
left a comment
Tao-Galasse
left a comment
There was a problem hiding this comment.
Très cool l'utilisation du concern, bravo :) 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.