Conversation
…git-intern-2025-term1 into massan/add-support-binary-files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
詳細
utf-8で処理していたものをバイナリで処理するよう変更したため、写真などその他のファイルをaddできるようになりました。
変更内容
add.ts
ファイル読み込みを utf-8 -> バイナリ に変更
blob.ts
GitBlobObject.content を string -> Buffer に変更
それによるcontent周りの処理をBufferに対応するよう変更
確認してほしいこと
Bufferのあたりの処理が自分でもよくわかってないので確認をお願いしたいです
自分の環境では60mbのpngファイルをadd、commitまでできました
デバッグ
mkdir example
cd example
git init
mygit add image.png