fix: import Html\Html for 1.44 by rti · Pull Request #42 · ProfessionalWiki/WikibaseEdtf

rti · 2025-07-08T08:00:49Z

Fix import MediaWiki\Html\Html for MediaWiki 1.44.

https://phabricator.wikimedia.org/T166010
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1120610/5/includes/Html/Html.php

Summary by CodeRabbit

Chores
- Updated extension to version 3.0.0 with raised minimum MediaWiki requirement.
- Improved compatibility by updating continuous integration testing to support newer MediaWiki and PHP versions.

coderabbitai · 2025-07-08T08:02:05Z

📝 Walkthrough

Walkthrough

The extension version was updated to 3.0.0 with a raised minimum MediaWiki requirement. The CI workflow matrix was adjusted by removing older MediaWiki/PHP combinations and adding a new one for REL1_44 with PHP 8.3. The Html import in HumanizingHtmlFormatter was changed to a fully qualified namespace.

Changes

File(s)	Change Summary
extension.json	Updated extension version to 3.0.0 and raised minimum MediaWiki version to 1.40.0
.github/workflows/ci.yml	Modified PHPUnit test matrix: removed older MediaWiki/PHP combos, added REL1_44 with PHP 8.3
src/Services/HumanizingHtmlFormatter.php	Updated Html import to use fully qualified namespace MediaWiki\Html\Html

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f64cba1 and 20838f0.

📒 Files selected for processing (2)

.github/workflows/ci.yml (1 hunks)
extension.json (2 hunks)

✅ Files skipped from review due to trivial changes (2)

.github/workflows/ci.yml
extension.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/Services/HumanizingHtmlFormatter.php (2)
78-84: Parameter $Html shadows the Html class and breaks camel-case conventions

Using an upper-case $Html variable invites confusion with the imported Html class and violates PSR naming style. Rename the parameter to $html (lower-case) and adjust its usages.
-private function warpInEdtfDiv( string $Html ): string {
+private function warpInEdtfDiv( string $html ): string {
     return Html::rawElement(
         'div',
         [ 'class' => 'edtf-value' ],
-        $Html
+        $html
     );
 }
25-32: Add explicit return type to format for stricter contracts

ValueFormatter::format is expected to return a string (per the common interface in ValueFormatters). Declaring the return type here tightens static analysis and prevents accidental mistakes.
- public function format( $edtf ) {
+ public function format( $edtf ): string {

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a3597aa and f64cba1.

📒 Files selected for processing (1)

src/Services/HumanizingHtmlFormatter.php (1 hunks)

🔇 Additional comments (1)

src/Services/HumanizingHtmlFormatter.php (1)

13-13: Import update aligns with MW 1.44 namespace – looks good

Switching to MediaWiki\Html\Html is required as of MW 1.44 and prevents autoloader failures at runtime.

JeroenDeDauw · 2025-07-08T21:20:07Z

What is the min MW version needed for this?

alistair3149 · 2025-07-08T21:39:09Z

What is the min MW version needed for this?

The MediaWiki\Html\Html class is introduced since MW 1.40, and the old Html alias is removed in MW 1.44

JeroenDeDauw · 2025-07-08T21:47:16Z

Let's do a release before we raise min MW version to 1.40

JeroenDeDauw · 2025-07-08T21:47:50Z

I'll do that now

JeroenDeDauw · 2025-07-08T21:58:09Z

Done. Tagged 2.1.2

@rti please update https://github.com/ProfessionalWiki/WikibaseEdtf/blob/master/.github/workflows/ci.yml#L19-L32 by removing MW < 1.40 and adding 1.44. Also update extension.json: MediaWIki version, and bump WikibaseEDTF to 3.0.0

rti · 2025-07-09T06:06:36Z

@JeroenDeDauw done

fix: import Html\Html for 1.44

f64cba1

coderabbitai bot reviewed Jul 8, 2025

View reviewed changes

rti mentioned this pull request Jul 8, 2025

chore!: bump mediawiki to 1.44.0 wmde/wikibase-release-pipeline#874

Merged

rti and others added 4 commits July 9, 2025 06:02

ci: remove mw < 1.40, add 1.44 on php 8.3

ba1d4ae

chore(extension.json): min mw version 1.40.0

12a25c4

chore(extension.json): bump version to 3.0.0

60863d1

Merge branch 'master' into fix-import-mediawiki-1.44

20838f0

JeroenDeDauw merged commit 27dc240 into ProfessionalWiki:master Jul 9, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: import Html\Html for 1.44#42

fix: import Html\Html for 1.44#42
JeroenDeDauw merged 5 commits intoProfessionalWiki:masterfrom
rti:fix-import-mediawiki-1.44

rti commented Jul 8, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 8, 2025 •

edited

Loading

Walkthrough

Changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

JeroenDeDauw commented Jul 8, 2025

Uh oh!

alistair3149 commented Jul 8, 2025

Uh oh!

JeroenDeDauw commented Jul 8, 2025

Uh oh!

JeroenDeDauw commented Jul 8, 2025

Uh oh!

JeroenDeDauw commented Jul 8, 2025

Uh oh!

rti commented Jul 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rti commented Jul 8, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

JeroenDeDauw commented Jul 8, 2025

Uh oh!

alistair3149 commented Jul 8, 2025

Uh oh!

JeroenDeDauw commented Jul 8, 2025

Uh oh!

JeroenDeDauw commented Jul 8, 2025

Uh oh!

JeroenDeDauw commented Jul 8, 2025

Uh oh!

rti commented Jul 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rti commented Jul 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)