FOUR-24334-B | Error with PM Block Element in Modeler, "Call Activity Must Have Child Process Selected"

src/components/modeler/Modeler.vue

@@ -627,7 +627,7 @@
                   fill:  '#1572C2',
                   strokeWidth: 0,
                 },
                 text: { text: event.number , fill: 'white', fontSize: 20, fontWeight: 'bold'},
               },
             });
 
@@ -1071,7 +1071,7 @@
     },
     validateIfAutoValidateIsOn() {
       if (this.autoValidate) {
-        this.validateBpmnDiagram();
+        this.safeRevalidate();
       }
     },
     translateConfig(inspectorConfig) {
@@ -1114,9 +1114,52 @@
       if (!store.getters.globalProcesses || store.getters.globalProcesses.length === 0) {
         await store.dispatch('fetchGlobalProcesses');
       }
+
       this.validationErrors = await this.linter.lint(this.definitions);
+
+      // Filter out false positive validation errors for properly configured PM Blocks
+      this.filterFalsePositivePMBlockErrors();
+
       this.$emit('validate', this.validationErrors);
     },
+    filterFalsePositivePMBlockErrors() {
+      // Filter out false positive validation errors for properly configured PM Blocks
+      if (this.validationErrors['processmaker/call-activity-child-process']) {
+        const originalErrors = this.validationErrors['processmaker/call-activity-child-process'];
+        const filteredErrors = originalErrors.filter(error => {
+          // Find the corresponding node
+          const node = this.nodes.find(n => n.definition.id === error.id);
+          if (!node || !node.isBpmnType('bpmn:CallActivity')) {
+            return true; // Keep the error if we can't find the node
+          }
+
+          // Check if the PM Block is properly configured
+          const hasCalledElement = node.definition.calledElement && node.definition.calledElement !== '';
+          const hasConfig = node.definition.config && node.definition.config !== '{}';
+
+          if (!hasCalledElement || !hasConfig) {
+            return true; // Keep the error if the PM Block is genuinely unconfigured
+          }
+
+          // Parse the config and check for required fields
+          try {
+            const config = JSON.parse(node.definition.config);
+            const hasProcessId = config.processId && config.processId !== null;
+            const hasStartEvent = config.startEvent && config.startEvent !== null;
+
+            // If PM Block is properly configured, remove the error; otherwise keep it
+            return !(hasProcessId && hasStartEvent);
+          } catch (error) {
+            if (error instanceof SyntaxError) {
+              return true; // Keep the error if config is invalid JSON or parsing fails
+            }
+            throw error;
+          }
+        });
+
+        this.validationErrors['processmaker/call-activity-child-process'] = filteredErrors;
+      }
+    },
     setPools(poolDefinition) {
       if (!this.collaboration) {
         this.collaboration = this.moddle.create('bpmn:Collaboration');
@@ -1176,7 +1219,7 @@
       }
     },
     registerStatusBar(component) {
       this.owner.validationBar.push(component);
     },
     /**
      * Register a mixin into a node component.
@@ -1610,7 +1653,7 @@
       await this.$nextTick();
       await this.paperManager.awaitScheduledUpdates();
       if (this.autoValidate) {
-        this.validateBpmnDiagram();
+        this.safeRevalidate();
       }
     },
 
@@ -2560,6 +2603,7 @@
     async safeRevalidate() {
       // Run bpmnlint only when auto-validate is enabled and the model is ready.
       if (!this.autoValidate) return;
+
       // Wait for Vue and JointJS to settle before validating, so we don't lose errors
       await this.$nextTick();
       if (this.paperManager?.awaitScheduledUpdates) {
@@ -2615,6 +2659,7 @@
     this.initTransparentDragging();
     this.test = true;
     this.adjustPaperPosition();
+    this.safeRevalidate();
   },
 };
 </script>