Add Set Favorite account functionality

[stupidly-logical]

Changes for functionality requested in #67

[Pritom14]

If there are changes in the UI could you please add the screenshot in the screenshot folder

[stupidly-logical]

Added.

[Pritom14]

The only problem with this PR is that when I set a favorite account by clicking on the star icon, it sets it to favorite (by filling the star icon). But when I go on adding a new account, it deselects it from favorite.
Could you please look into the issue?

[stupidly-logical]

Will check.

[stupidly-logical]

@Pritom14 Issue fixed.

[stupidly-logical]

@Pritom14 Checked?

[Pritom14]

@stupidly-logical I have mentioned the change to be made. Just remove the private keyword

[stupidly-logical]

@Pritom14 I can't find where you've mentioned. Kindly guide.

[Pritom14]

@stupidly-logical go to the Files Changed tab, and then go to the PasswordRecyclerViewAdapter class where you will find the review at line no. 202

[stupidly-logical]

That ImageView needed to be added because of PR Quality Issue.

[stupidly-logical]

https://app.codacy.com/app/Pritom14/Password-Storage/file/23570889520/issues/source?fileBranchId=9037891

[Pritom14]

@stupidly-logical , since @BindView fields cannot be private or static, so just remove the private keyword. So after changes the line would be ImageView iconFav;

[stupidly-logical]

But then it will not pass check in Codacy check like this. : https://app.codacy.com/app/Pritom14/Password-Storage/file/23570889520/issues/source?fileBranchId=9037891

[Pritom14]

Did you run this in Android-Studio, because when I pull the PR, it shows an error stating that @BindViews cannot be private or static

[stupidly-logical]

Yes but for passing the Code Review test I had to make it private.

If you are okay with the Code Review error, I'll remove the private keyword and push?

[Pritom14]

Okay, let it be. I will commit the change from my side

[stupidly-logical]

No problem. I am pushing the change.

[Pritom14]

@stupidly-logical , don't!!!. Let it be private. I will make the change from my side

[stupidly-logical]

Ok.

[Pritom14]

Will it be ok, if I give the review on the code tomorrow, because the device on which I am testing the app is having some problem.

[Pritom14]

Till then you could check out more projects or could find out more issues to work on

[stupidly-logical]

Completely fine with me. Take your time. 👍

[Pritom14]

@stupidly-logical have you tested this in an android device, because I am not getting the desired result. If there is some favorite account set, and you create a new account in the app, the favorite icon unset by itself. Also I am unable to unset the favorite account manually

[stupidly-logical]

Yes I was getting the desired result and I also fixed the issue that you pointed out that it was setting it back to not favorite when you add a new account. Give me some time. I'll check once again. Please make sure that you pulled my branch properly too.

[Pritom14]

I checked the pulled PR twice, but I am getting the same results. I'll check it once again and let you know

…

On Wed, 10 Oct, 2018, 1:41 AM Yash Krishan Verma, ***@***.***> wrote: Yes I was getting the desired result and I also fixed the issue that you pointed out that it was setting it back to not favorite when you add a new account. Give me some time. I'll check once again. Please make sure that you pulled my branch properly too. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#91 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APzU4oThXn-Axy3AznYmLOy5A4AV8S8oks5ujQL5gaJpZM4XEKm_> .

[stupidly-logical]

Ok. I'll check too.

[stupidly-logical]

@Pritom14 Meanwhile I've found some issues when I analyzed the code. I'll create an issue and make PR.

[stupidly-logical]

@Pritom14 I've removed private keyword and tested the functionality. It is working as desired.