Skip to content

Video Splash Added#71

Open
ishudohare wants to merge 1 commit intoPritom14:masterfrom
ishudohare:master
Open

Video Splash Added#71
ishudohare wants to merge 1 commit intoPritom14:masterfrom
ishudohare:master

Conversation

@ishudohare
Copy link

@ishudohare ishudohare commented Dec 22, 2017

Designed a new layout for the splash screen with an animated video.
3 files changed-
Edited-SplashActivity
splash layout xml file
Added the "splash_final.mp4" in Res/raw folder

let me know if there is any issue with the pull request.

Splash Issue resolved
@ishudohare
Copy link
Author

@Pritom14 ,pls review the PR

@Pritom14
Copy link
Owner

Pritom14 commented Jan 7, 2018

Really sorry for taking such a long time to reply, @ishudohare
As for now I will keep the PR on hold as because someone is making a logo for the app and then the logo can be added in your PR. Hope you don't mind

@ishudohare
Copy link
Author

ishudohare commented Jan 7, 2018 via email

@Pritom14
Copy link
Owner

Pritom14 commented Jan 7, 2018 via email

@ishudohare
Copy link
Author

ishudohare commented Jan 8, 2018 via email

@Pritom14
Copy link
Owner

Pritom14 commented Jan 8, 2018

Have you submitted the report?

@ishudohare
Copy link
Author

ishudohare commented Jan 8, 2018 via email

@ishudohare
Copy link
Author

ishudohare commented Jan 8, 2018 via email

@Pritom14
Copy link
Owner

Pritom14 commented Jan 8, 2018 via email

@ishudohare
Copy link
Author

ishudohare commented Jan 8, 2018 via email

@Pritom14
Copy link
Owner

Pritom14 commented Jan 8, 2018

Currently I am not merging the PR because of the logo, I will when one of my colleagues will finish designing the logo. Please don't mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants