This repository was archived by the owner on Jan 24, 2018. It is now read-only.
Added support for options.skrollrBody#733
Open
LufoX11 wants to merge 6 commits intoPrinzhorn:masterfrom
LufoX11:master
Open
Added support for options.skrollrBody#733LufoX11 wants to merge 6 commits intoPrinzhorn:masterfrom LufoX11:master
LufoX11 wants to merge 6 commits intoPrinzhorn:masterfrom
LufoX11:master
Conversation
Author
|
More improvements to be fully compatible with last JQM version. |
Owner
|
I agree that a skrollrBody option may be useful. But I will not mix jqm specific code into skrollr. |
Author
|
I think that if you want your plugin to be mobile compatible it should be compatible with popular mobile frameworks. they all (not only jqm) catch and play with touch events like you do, so this change is necessary for all of them. I didn't add any jq/jqm specific platform code but pure js. you can't use it in jqm if you don't make those changes. even more, I improved it fixing other stuff not related to jqm. it's all documented. thanks for your excelent work! |
Author
|
moreover, allowing a custom selector is a more flexible option that's not related to jqm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows options.skrollrBody to be also a DOM node with the container already set. I had to do this because of JQM and its load structure.