This repository was archived by the owner on Jan 24, 2018. It is now read-only.
Let's not preventDefault touchstart events.#415
Open
realyze wants to merge 2 commits intoPrinzhorn:masterfrom
Open
Let's not preventDefault touchstart events.#415realyze wants to merge 2 commits intoPrinzhorn:masterfrom
realyze wants to merge 2 commits intoPrinzhorn:masterfrom
Conversation
Not calling preventDefault for touchStart events. It breaks scrolling on Androids big time.
Removed newline at the end of file.
Owner
|
I don't think it's that easy. iScroll does this https://github.com/cubiq/iscroll/blob/master/build/iscroll-lite.js#L88 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the android scroll-while-finger-is-on-screen issue. PDing
touchmovesmakes sense on Androids but I don't thinktouchstarts should ever be preventDefault'ed.