This repository was archived by the owner on Jan 24, 2018. It is now read-only.
- fix for when keyframes are combined.#38
Open
kodybrown wants to merge 6 commits intoPrinzhorn:masterfrom
Open
- fix for when keyframes are combined.#38kodybrown wants to merge 6 commits intoPrinzhorn:masterfrom
kodybrown wants to merge 6 commits intoPrinzhorn:masterfrom
Conversation
Owner
|
Please post an example. Or even better add a test case to the test suit. Because just by looking at the code I don't know what input you're trying to handle. |
- Class attributes without trailing spaces - Stylesheet with multiple @-skrollr-keyframes and no trailing spaces * External stylesheet precedence
Conflicts: README.md src/skrollr.stylesheets.js test/tests.js
Collaborator
|
Ping @kodybrown, please please post us an example so we can get this pull request wrapped up 🎁 |
Author
|
There are three tests in there? |
Collaborator
|
@Prinzhorn I had a look at the tests, looks ok to me. Lets get this merged. |
Owner
|
@evolve2k I've added you as a collaborator. Feel free to give some new live to this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I have created multiple keyframes (dynamically via sass) they are combined without semi-colon.
Apparently, the document parser trims trailing semi-colons from stylesheet rules..