Skip to content

Issue 1626 - Moves setup and constants to core, deprecates globals, __default_file__#1650

Open
lsawade wants to merge 4 commits intodevelfrom
issue-1626
Open

Issue 1626 - Moves setup and constants to core, deprecates globals, __default_file__#1650
lsawade wants to merge 4 commits intodevelfrom
issue-1626

Conversation

@lsawade
Copy link
Collaborator

@lsawade lsawade commented Feb 13, 2026

Description

  • deprecates setup
  • makes constants non config file
  • deprecates globals unused

Issue Number

Closes #1626

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • THE DOCUMENTATION BUILDS WITHOUT WARNINGS/ERRORS
  • I have added labels to the PR (see right hand side of the PR page)
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@lsawade lsawade requested a review from icui February 13, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant