Skip to content

Code cleaning / Refactoring #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
therealtx wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Code cleaning / Refactoring #359

therealtx wants to merge 6 commits into from

Conversation

@therealtx
Copy link

@therealtx therealtx commented Jan 25, 2022

This is very big commit with with refactoring.

@vercel
Copy link

vercel bot commented Jan 25, 2022

Someone is attempting to deploy this pull request to the Nearapps Team on Vercel.

To accomplish this, the commit author's email address needs to be associated with a GitHub account.

Learn more about how to change the commit author information.

biswanathsahoo
biswanathsahoo suggested changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@biswanathsahoo biswanathsahoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please do a rebase with dev and fix the conflicts

@therealtx
Copy link
Author

therealtx commented Jan 25, 2022 •
edited
Loading

Can you please do a rebase with dev and fix the conflicts

Done.
Edit: not done yet.

@therealtx therealtx force-pushed the tigran/LP-41_code_cleaning branch from de6cd0f to c5bfa20 Compare January 26, 2022 04:19
@therealtx
Copy link
Author

therealtx commented Jan 26, 2022

Can you please do a rebase with dev and fix the conflicts

Now it's ready for review I think.

@biswanathsahoo
Copy link
Contributor

biswanathsahoo commented Jan 27, 2022

@therealtx There are still some conflict as other peoples are working on some issues and I did review for some component and I think this code cleanup may break any flow. There will be lots of conflict in this process. So I would suggest let's do the refactoring in chunk component by component. Let's give PR for each component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@biswanathsahoo biswanathsahoo Awaiting requested review from biswanathsahoo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@therealtx @biswanathsahoo