This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Allowing 0% discount (no discount) for abandoned cart reminders#6
Open
vallka wants to merge 2 commits intoPrestaShop:devfrom
Open
Allowing 0% discount (no discount) for abandoned cart reminders#6vallka wants to merge 2 commits intoPrestaShop:devfrom
vallka wants to merge 2 commits intoPrestaShop:devfrom
Conversation
vallka
changed the title
Member
|
Hello @vallka , thanks for your contribution, would you mind to rebase your pull request? Thanks |
Progi1984
reviewed
Mar 12, 2020
| ); | ||
| if (false !== $voucher) { | ||
| // allowing to use 0 discount | ||
| //if (false !== $voucher) { |
Member
There was a problem hiding this comment.
Please remove commented line ;)
Co-Authored-By: LouiseBonnard <32565890+LouiseBonnard@users.noreply.github.com>
|
Hi @vallka, thanks for your contribution here! Do you want this behavior (leave 0 to disable the discount) to apply to all module cases (namely canceled carts, validated carts, good and bad customers) or only to the canceled carts case? |
Author
|
Yes, it would be consistent - to all cases
thanks
Valentine
…------ Original Message ------
From: "LouiseBonnard" <notifications@github.com>
To: "PrestaShop/ps_reminder" <ps_reminder@noreply.github.com>
Cc: "Valentine" <vallka@vallka.com>; "Mention"
<mention@noreply.github.com>
Sent: 17/04/2020 15:58:54
Subject: Re: [PrestaShop/ps_reminder] Allowing 0% discount (no discount)
for abandoned cart reminders (#6)
Hi @vallka <https://github.com/vallka>, thanks for your contribution
here! Do you want this behavior (leave 0 to disable the discount) to
apply to all module cases (namely canceled carts, validated carts, good
and bad customers) or only to the canceled carts case?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADBMNHJAPZJ35L7QQDRWCI3RNBVC5ANCNFSM4GF67KMQ>.
--
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
|
|
Actually, it can only be applied to canceled carts, other follow up emails are not compatible as they all mention the discount. I, therefore, suggest to:
|
Member
|
Hello @vallka , thanks for your contribution, would you mind to rebase your pull request? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ver. 1.6.* it was possible to send simple reminders with no discounts