Skip to content

Api admin route : SwitchDebugMode#112

Open
Mch0 wants to merge 5 commits intoPrestaShop:devfrom
Mch0:mch0/debug
Open

Api admin route : SwitchDebugMode#112
Mch0 wants to merge 5 commits intoPrestaShop:devfrom
Mch0:mch0/debug

Conversation

@Mch0
Copy link

@Mch0 Mch0 commented Nov 22, 2025

Questions Answers
Description? Add api admin route for SwitchDebugModeCommand
Type? improvement / new feature
BC breaks? no
Deprecations? no
Sponsor company Griiv
How to test? Api endpoint : /debug/toggle

@ps-jarvis
Copy link

Hello @Mch0!

This is your first pull request on ps_apiresources repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Arnaud!

Great to see your contribution there!

Please consider adding integration tests; there are some examples in other endpoints that have already been added.

There's also some commented code in your pull request. If you are still working on the PR, you can mark it as a draft 👍🏻

@ps-jarvis ps-jarvis moved this from Ready for review to Waiting for author in PR Dashboard Nov 22, 2025
@Mch0
Copy link
Author

Mch0 commented Nov 23, 2025

Hello Arnaud!

Great to see your contribution there!

Please consider adding integration tests; there are some examples in other endpoints that have already been added.

There's also some commented code in your pull request. If you are still working on the PR, you can mark it as a draft 👍🏻

Hello kpodemski,

Thanks for your reply, im going to do it

@Mch0 Mch0 requested a review from kpodemski November 23, 2025 10:53
nicosomb
nicosomb previously approved these changes Nov 27, 2025
@ps-jarvis ps-jarvis added the Waiting for QA Status: Waiting for QA feedback label Nov 27, 2025
@ps-jarvis ps-jarvis moved this from Waiting for author to To be tested in PR Dashboard Nov 27, 2025
@nicosomb nicosomb added Waiting for author and removed Waiting for author Waiting for QA Status: Waiting for QA feedback labels Nov 28, 2025
@ps-jarvis ps-jarvis moved this from To be tested to Waiting for author in PR Dashboard Nov 28, 2025
@nicosomb
Copy link
Contributor

@Mch0 some tests are red.

@kpodemski
Copy link
Contributor

Hello @Mch0

There are still some tests that are red.

@kpodemski kpodemski closed this Jan 23, 2026
@github-project-automation github-project-automation bot moved this from Waiting for author to Closed in PR Dashboard Jan 23, 2026
@kpodemski kpodemski reopened this Jan 23, 2026
@github-project-automation github-project-automation bot moved this from Closed to Reopened in PR Dashboard Jan 23, 2026
@ps-jarvis ps-jarvis moved this from Reopened to Closed in PR Dashboard Jan 23, 2026
@ps-jarvis ps-jarvis moved this from Closed to Reopened in PR Dashboard Jan 23, 2026
@kpodemski
Copy link
Contributor

Hello @Mch0

Just a quick heads-up: reviews on pending Admin API PRs will start in the coming days.

We first took some time to clarify and unify the Admin API contribution rules and ADR expectations. With that work done, the team will now review existing PRs based on those updates.

Thanks for your patience. Feedback will follow directly on the PR.

@ps-jarvis ps-jarvis moved this from Reopened to Waiting for author in PR Dashboard Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Waiting for author

Development

Successfully merging this pull request may close these issues.

4 participants