Skip to content

fix: avoid $currentIndex #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PrestaEdit wants to merge 2 commits into from
Closed

fix: avoid $currentIndex #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e23ed6f
fix: avoid $currentIndex
PrestaEdit Aug 6, 2025
8508703
fix: artifact GitHub Actions in v4
PrestaEdit Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Generate index.php
run: ~/.composer/vendor/bin/autoindex
- name: Create & upload artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ github.event.repository.name }}
path: /home/runner/work/${{ github.event.repository.name }}
Expand All @@ -27,7 +27,7 @@ jobs:
if: github.event_name == 'push' && (github.event.ref == 'refs/heads/main' || github.event.ref == 'refs/heads/master')
steps:
- name: Download artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ github.event.repository.name }}
path: ${{ github.event.repository.name }}
Expand Down
2 changes: 1 addition & 1 deletion productcomments.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ public function renderModerateLists()
$helper->table = $this->name;
$helper->table_id = 'waiting-approval-productcomments-list';
$helper->token = Tools::getAdminTokenLite('AdminModules');
$helper->currentIndex = AdminController::$currentIndex . '&configure=' . $this->name;
$helper->currentIndex = $this->context->link->getAdminLink('AdminModules', true) . '&configure=' . $this->name;
$helper->no_link = true;

$return .= $helper->generateList($comments, $fields_list);
Expand Down
Loading