Fix: Removed the "updateRating" event#217
Conversation
Codencode
commented
Jul 28, 2025
| Questions | Answers |
|---|---|
| Description? | see: PrestaShop/PrestaShop#39218 |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#39218 |
| How to test? | see: PrestaShop/PrestaShop#39218 |
| Sponsor company | @Codencode |
|
Hello @Codencode Thank you for this pull request. When you remove the code, it's worth checking who added it and for what reason. You can do that by opening the file on GitHub, clicking on the line, and usingthe "Git blame" feature: You can see that this part of the code was added for a reason: Could you take a look and see if removing this code won't create a regression by bringing back the already fixed issue? |
|
Hello @kpodemski, you're absolutely right. I tried tracking down which PR introduced that code but couldn't find it initially - then using git blame (as you suggested) I located it. After testing, I can confirm the issue (PrestaShop/PrestaShop#15184) either no longer occurs or at least I couldn't reproduce it. Something must have changed in the meantime, so that line/instruction is likely no longer needed. |
|
The only concern I have now is that if someone uses the |
|
I looked into it further, and indeed the change is not needed. |
|
I'm closing this because the issue has already been resolved with this PR: b93d8bf |
