Conversation
kpodemski
left a comment
There was a problem hiding this comment.
Hello @rodriciru
Could you double-check if it is really needed to load the class? It really shouldn't be.
|
Hello.
Now, I don't have time for this, but I'm pretty sure that I need to include this class.
At least at that moment.
|
matks
left a comment
There was a problem hiding this comment.
As @rodriciru mentioned there are other require in this module so although it looks strange it seems this module needs manual loads.
CI is red but I re-run it
|
I move the include location to the top, so the hookFilterProductContent method can access ProductComment class. For clarification, whitout move the include i get this: |
|
Hello, This PR should be tested with the PR "Add products reviews to schema.org " PrestaShop/hummingbird#319 which presents a branch conflict! So this PR will be blocked until the other one will be waiting for QA. Thanks! |
|
I have asked if the PR is still blocked in PrestaShop/hummingbird#319 |


Related PR and issues:
PrestaShop/hummingbird#319
PrestaShop/PrestaShop#28719
I try to do in theme files but google complains about it because we can't link the product schema whit the microdata or json+ld on .tpl (Really you can (@id or itemref) but it still complains because on product schema theres no direct ref to the reviews.
So the best option is add to the module