This repository was archived by the owner on Feb 3, 2021. It is now read-only.
When out of stock, Email should be required when customer not logged in #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the consistent check whether the email addres should be possible to provide by user - the actions.php controller checks if customer is logged in to decide wheter to take email from parameter or from customer context. This change prevents the scenario whit missing email information when customer has the account but is not logged in when making the request.
Contributor
|
Hi! Can you recreate your pull request on the dev branch? Thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the consistent check whether the email addres should be possible to provide by user - the actions.php controller checks if customer is logged in to decide wheter to take email from parameter or from customer context. This change prevents the scenario whit missing email information when customer has the account but is not logged in when making the request.