Skip to content

Conversation

@ShaiMagal
Copy link

@ShaiMagal ShaiMagal commented Aug 21, 2025

Questions Answers
Description? Below
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?

Description:

I don't know how this happened. "Randomly" I found this in php error logs, I can't reproduce it, but I see in logs sometimes.

dashproducts 2.1.4
PS 8.2.2
PHP 7.2

[21-Aug-2025 16:41:45 Europe/Prague] PHP Warning: Invalid argument supplied for foreach() in XXX/modules/dashproducts/dashproducts.php on line 219
[21-Aug-2025 16:41:56 Europe/Prague] PHP Warning: Invalid argument supplied for foreach() in XXX/modules/dashproducts/dashproducts.php on line 219
[21-Aug-2025 16:56:24 Europe/Prague] PHP Warning: Invalid argument supplied for foreach() in XXX/modules/dashproducts/dashproducts.php on line 219
[21-Aug-2025 17:27:39 Europe/Prague] PHP Warning: Invalid argument supplied for foreach() in XXX/modules/dashproducts/dashproducts.php on line 219
[21-Aug-2025 18:18:25 Europe/Prague] PHP Warning: Invalid argument supplied for foreach() in XXX/modules/dashproducts/dashproducts.php on line 219
[21-Aug-2025 18:45:00 Europe/Prague] PHP Warning: Invalid argument supplied for foreach() in XXX/modules/dashproducts/dashproducts.php on line 219

@ShaiMagal ShaiMagal changed the title Warning products fix PHP Warning - $products fix Aug 21, 2025
@ShaiMagal ShaiMagal changed the title PHP Warning - $products fix DRAFT PHP Warning - $products fix Aug 21, 2025
@ShaiMagal ShaiMagal changed the title DRAFT PHP Warning - $products fix PHP Warning - $products fix Aug 21, 2025
@ShaiMagal ShaiMagal marked this pull request as ready for review August 21, 2025 23:15
@ps-jarvis
Copy link

Hello @ShaiMagal!

This is your first pull request on dashproducts repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Aug 21, 2025
@ShaiMagal
Copy link
Author

ShaiMagal commented Aug 21, 2025

I don't know what's wrong with PHPStan test.
"Error: Process completed with exit code 255."
https://github.com/PrestaShop/dashproducts/actions/runs/17141379925/job/48629342625?pr=62

Error response from daemon: No such container: temp-ps
ps-volume
Unable to find image 'prestashop/prestashop:latest' locally

@Hlavtox
Copy link
Contributor

Hlavtox commented Aug 22, 2025

@PrestaShop/prestashop-core-developers CI broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

4 participants