Fix: make /attachments/{attachmentId} endpoint work by adding AttachmentId to EditableAttachment and renaming attachmentIdValue to attachmentId in GetAttachmentForEditing#39966
Open
Codencode wants to merge 3 commits intoPrestaShop:9.0.xfrom
Conversation
|
Hi, thanks for this contribution! I found some issues with the Pull Request description:
Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much! (Note: this is an automated message, but answering it will reach a real human) |
…o attachmentId in GetAttachmentForEditing (fix /attachments/{attachmentId} endpoint)
Codencode
force-pushed
the
fix/attachment-endpoint-editable-attachment
branch
from
0e6971d to
1f270fd
Compare
…chments/{attachmentId} endpoint)
Contributor
Author
|
@tleon @nicosomb @boherm Thanks a lot 🙏 |
Codencode
force-pushed
the
fix/attachment-endpoint-editable-attachment
branch
from
64bb3fc to
1b73c0e
Compare
…Name(), setFileSize(). setMimeType(), setOriginalName() methods
Codencode
force-pushed
the
fix/attachment-endpoint-editable-attachment
branch
from
1b73c0e to
4caf945
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add AttachmentId to EditableAttachment and rename attachmentIdValue to attachmentId in GetAttachmentForEditing (fix /attachments/{attachmentId} endpoint)
/attachments/{attachmentId}API endpoint, currently being developed in PrestaShop/ps_apiresources#105.🐛 Fixes
- Fixed the
/attachments/{attachmentId}endpoint by adding theAttachmentIdparameter toEditableAttachmentand renamingattachmentIdValue→attachmentIdinGetAttachmentForEditing.- Ensures correct mapping and retrieval of attachment data for API serialization/deserialization.
🧱 Refactors
-
EditAttachmentCommand: constructor now acceptsint $attachmentIdinstead of anAttachmentIdvalue object, ensuring compatibility with API Platform.-
AddAttachmentCommandandEditAttachmentCommand: added setterssetPathName(),setFileSize(),setMimeType(),setOriginalName()to improve flexibility when building commands from uploaded file metadata.