Skip to content

Conversation

@kingsley-123
Copy link

@kingsley-123 kingsley-123 commented Oct 26, 2025

Summary

Fixes #444.

Added comprehensive examples for environment variables, secret references, and image pull secrets configuration in the baseJobTemplate.

Requirements

  • Contributing guide has been read
  • Title follows the conventional commits format
  • Body includes Closes <issue>, if available
  • Added/modified configuration includes a descriptive comment for documentation generation
  • Unit tests are added/updated
  • Deprecation/removal checks are added in templates/NOTES.txt
  • Relevant labels are added
  • Draft status is used until ready for review

@kingsley-123 kingsley-123 requested a review from a team as a code owner October 26, 2025 22:41
@kingsley-123 kingsley-123 had a problem deploying to Acceptance Tests (External) October 26, 2025 22:41 — with GitHub Actions Failure
@kingsley-123 kingsley-123 had a problem deploying to Acceptance Tests (External) October 26, 2025 22:41 — with GitHub Actions Failure
@kingsley-123 kingsley-123 had a problem deploying to Acceptance Tests (External) October 26, 2025 22:41 — with GitHub Actions Failure
@kingsley-123 kingsley-123 had a problem deploying to Acceptance Tests (External) October 26, 2025 22:41 — with GitHub Actions Failure
@kingsley-123 kingsley-123 had a problem deploying to Acceptance Tests (External) October 26, 2025 22:41 — with GitHub Actions Failure
@kingsley-123 kingsley-123 had a problem deploying to Acceptance Tests (External) October 26, 2025 22:41 — with GitHub Actions Failure
@kingsley-123 kingsley-123 had a problem deploying to Acceptance Tests (External) October 26, 2025 22:41 — with GitHub Actions Failure
@kingsley-123 kingsley-123 had a problem deploying to Acceptance Tests (External) October 26, 2025 22:41 — with GitHub Actions Failure
@mitchnielsen mitchnielsen changed the title Docs: Expand baseJobTemplate documentation #444 docs: expand baseJobTemplate documentation #444 Oct 27, 2025
@mitchnielsen mitchnielsen changed the title docs: expand baseJobTemplate documentation #444 docs: expand baseJobTemplate documentation Oct 27, 2025
@mitchnielsen
Copy link
Contributor

Thanks so much for picking this one up @kingsley-123.

When I started reviewing this, I couldn't help but think this documentation probably fits better in the Prefect repo because this isn't specific to the Helm charts - all users could benefit from clearer notes on this topic.

I looked through what docs we have on this so far and found two relevant pages:

What do you think? Will also loop in @zzstoatzz

@kingsley-123
Copy link
Author

kingsley-123 commented Oct 29, 2025

@mitchnielsen

Hi,

Thanks for reviewing my PR and for your thoughtful feedback. I appreciate the suggestion about potentially moving this documentation to the main Prefect repository for wider visibility.

I agree that these examples would benefit all users, not just those using the Helm charts. I'm happy to take either approach:

  1. Continue with this PR to improve the Helm-specific documentation
  2. Close this PR and create a new one in the main Prefect repository with expanded examples
  3. Do both - keep simpler notes here while creating more comprehensive documentation in the main repo

I also noticed one of the tests is failing for version 1.31.0 while passing for newer versions. Would you happen to have any logs or insights on what might be causing this issue?

Please let me know which direction you prefer, and I'll be glad to make the necessary adjustments. I'm committed to improving the documentation wherever it will be most helpful to users.

Thanks again for your guidance.

@mitchnielsen
Copy link
Contributor

  1. Do both - keep simpler notes here while creating more comprehensive documentation in the main repo

I'm leaning toward this option - we can provide a brief Helm-specific example of setting a custom base job template, and then link out to the Prefect docs for more details on how to configure that object.

I also noticed one of the tests is failing for version 1.31.0 while passing for newer versions. Would you happen to have any logs or insights on what might be causing this issue?

Looks like this may have been a transient error. I've retried the job and it passed.

I'm committed to improving the documentation wherever it will be most helpful to users.

Very much appreciated 🤝

Simplify baseJobTemplate documentation as requested
@kingsley-123 kingsley-123 had a problem deploying to Acceptance Tests (External) December 7, 2025 21:58 — with GitHub Actions Failure
@kingsley-123 kingsley-123 had a problem deploying to Acceptance Tests (External) December 7, 2025 21:58 — with GitHub Actions Failure
@kingsley-123 kingsley-123 had a problem deploying to Acceptance Tests (External) December 7, 2025 21:58 — with GitHub Actions Failure
@kingsley-123 kingsley-123 had a problem deploying to Acceptance Tests (External) December 7, 2025 21:58 — with GitHub Actions Failure
@kingsley-123 kingsley-123 had a problem deploying to Acceptance Tests (External) December 7, 2025 21:58 — with GitHub Actions Failure
@kingsley-123 kingsley-123 had a problem deploying to Acceptance Tests (External) December 7, 2025 21:58 — with GitHub Actions Failure
@kingsley-123 kingsley-123 had a problem deploying to Acceptance Tests (External) December 7, 2025 21:58 — with GitHub Actions Failure
@kingsley-123 kingsley-123 had a problem deploying to Acceptance Tests (External) December 7, 2025 21:58 — with GitHub Actions Failure
@kingsley-123
Copy link
Author

@mitchnielsen

Hi,

I've updated the PR to simplify the documentation as you requested. The changes now include:

  • A basic image pull secrets example specific to Helm usage
  • A reference link to the comprehensive documentation (which I'll create in the main Prefect repo as our next step)
  • Removed all the detailed examples to keep this focused on Helm-specific guidance

Ready for your review. Thanks for the guidance!

the snippet is truncated for brevity. The full configuration should still be
provided.

For comprehensive examples including environment variables, secret references, resource configurations, and advanced use cases, see the [Prefect base job template documentation](https://docs.prefect.io/latest/guides/deployment/kubernetes/#base-job-templates).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you would modify the `base-job-template.json` file to look like this:

```diff
```json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```json
```json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand documentation on how to use baseJobTemplate

2 participants