-
Notifications
You must be signed in to change notification settings - Fork 85
docs: expand baseJobTemplate documentation #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: expand baseJobTemplate documentation #566
Conversation
…ent variables and secrets PrefectHQ#444
|
Thanks so much for picking this one up @kingsley-123. When I started reviewing this, I couldn't help but think this documentation probably fits better in the Prefect repo because this isn't specific to the Helm charts - all users could benefit from clearer notes on this topic. I looked through what docs we have on this so far and found two relevant pages:
What do you think? Will also loop in @zzstoatzz |
|
Hi, Thanks for reviewing my PR and for your thoughtful feedback. I appreciate the suggestion about potentially moving this documentation to the main Prefect repository for wider visibility. I agree that these examples would benefit all users, not just those using the Helm charts. I'm happy to take either approach:
I also noticed one of the tests is failing for version 1.31.0 while passing for newer versions. Would you happen to have any logs or insights on what might be causing this issue? Please let me know which direction you prefer, and I'll be glad to make the necessary adjustments. I'm committed to improving the documentation wherever it will be most helpful to users. Thanks again for your guidance. |
I'm leaning toward this option - we can provide a brief Helm-specific example of setting a custom base job template, and then link out to the Prefect docs for more details on how to configure that object.
Looks like this may have been a transient error. I've retried the job and it passed.
Very much appreciated 🤝 |
Simplify baseJobTemplate documentation as requested
|
Hi, I've updated the PR to simplify the documentation as you requested. The changes now include:
Ready for your review. Thanks for the guidance! |
| the snippet is truncated for brevity. The full configuration should still be | ||
| provided. | ||
|
|
||
| For comprehensive examples including environment variables, secret references, resource configurations, and advanced use cases, see the [Prefect base job template documentation](https://docs.prefect.io/latest/guides/deployment/kubernetes/#base-job-templates). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this link is working for me. I wonder if we want one or both of these:
| you would modify the `base-job-template.json` file to look like this: | ||
|
|
||
| ```diff | ||
| ```json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ```json | |
| ```json |
Summary
Fixes #444.
Added comprehensive examples for environment variables, secret references, and image pull secrets configuration in the baseJobTemplate.
Requirements
Closes <issue>, if availabletemplates/NOTES.txtDraftstatus is used until ready for review