Open
Conversation
|
@warrickhill , can you review this PR and merge ? |
daninfpj
force-pushed
the
migrate-aws-sdk-v3
branch
from
5ff8fdf to
063feb5
Compare
clmsnskr
approved these changes
Jun 21, 2024
Author
|
Hi @warrickhill can we help to merge this? Anything missing? |
warrickhill
approved these changes
Sep 10, 2024
Author
|
@warrickhill thanks for the approval. However, I still can’t merge it, would you mind?
|
|
@warrickhill could you merge this please? |
Merges migrate-aws-sdk-v3 branch and adds 27 focused tests across three files covering the core logic: profile config parsing (including the new sso-session resolution), SSO access-token cache reading, and the main credential-fetch flow (happy path, cached-credential shortcut, expired creds, missing config, and auto-login trigger). - lib/index.js: add named exports for unit-testable internal functions - package.json: add vitest devDependency and `test` script - test/getConfigForProfile.test.js: 10 pure-logic unit tests - test/getAccessToken.test.js: 8 tests with fs mocking - test/main.test.js: 9 integration tests with full dependency mocking https://claude.ai/code/session_01CTx64ZxshU2LqM6jKGjKxo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17.