fixes to policy reload auth & SSRF whitelist for local services.#29
Merged
fixes to policy reload auth & SSRF whitelist for local services.#29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Fixes for GitHub Issues #26 and #27
Issue #26: Unauthenticated
/policy/reloadEndpointProblem: The
/policy/reloadendpoint accepted unauthenticated requests, allowing any local process to replace the policy with a permissive one.Solution:
reload_secretanddisable_reloadfields toPolicyConfiginsrc/config.rspolicy_reload_secretandpolicy_reload_disabledfields toAppStateinsrc/http/mod.rspolicy_reload_handlerto requireAuthorization: Bearer <token>when secret is configured/policy/reloadroute conditional - returns 404 whendisable_reloadis trueConfiguration:
--policy-reload-secretPREDICATE_POLICY_RELOAD_SECRET--disable-policy-reloadPREDICATE_DISABLE_POLICY_RELOADTOML Config: