HTML: Fully expand ToC to active item when subpage is navigated to #2733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, navigating to a ToC link that is a sub page element (subsubsection when chunks are sections) does not expand the ToC to all the way. (Since XSL only knows what chunk the page corresponds to, not what href within the page will be selected.)
This makes sure the path to the active ToC item is fully expanded.
Testing:
Use the first commit that changes SA ToC depth to 4.
Navigate to 4.6.2 and then refresh page.
ToC should look like:
Then apply second commit, rebuild to get fresh JS, and navigate to same place, then refresh.
Now you will get: