-
Notifications
You must be signed in to change notification settings - Fork 220
Publisher pagebreaks #2618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Publisher pagebreaks #2618
Conversation
ce9b832 to
f18d87f
Compare
I made a change that skirts the alert while leaving the feature functioning. There is a comment about this change now in I'm going to lift draft mode now. Although perhaps we still are not in love with "insertions". |
|
This should apply to |
|
This looks real good, but I think there is one big problem. Adding a Yes, authors should be using labels. But imagine a I have not manufactured an example. If you think this fear is unfounded, we can dig deeper. Approach I was thinking of before seeing above. Introduce an attribute on the element with the Also, if I was to merge this right now, I'd need to explode the second commit into four: publisher variable, assembly, LaTeX, Guide. There is a small merge conflict with the entities, it is easy to fix, look for an addition of |
|
Just checking, with limited understanding. But does it make any sense to exclude |
Had that thought. The automatic ids, as used in the two-pass generation processes with assembly is a brittle situation. So I don't really want to complicate the (very simple) routines doing the number parts of the automatic ids. |
|
OK, I'll change them to attributes. Unless...one last check. Would it make sense to just do these insertions all at the end, after "visible-id" is established too? You can just direct me to do use attributes if you'd rather not take time to explain. I'll take your word for it. |
That might work, but I really want to make the pre-processor simpler, not more complicated. It is really making me nervous these days. Now I'm wondering - why use -assembly at all? The publisher variable is great, and is globally available. Once into a block, test its |
|
Yes, the way it is now was in an effort to add minimal code. Just the one
template to -latex. That necessitated using an assembly pass. But if we let
that go, assembly is not needed.
Alex Jordan
Mathematics Instructor
Portland Community College
…On Tue, Aug 26, 2025, 5:13 PM Rob Beezer ***@***.***> wrote:
*rbeezer* left a comment (PreTeXtBook/pretext#2618)
<https://urldefense.com/v3/__https://github.com/PreTeXtBook/pretext/pull/2618*issuecomment-3226206742__;Iw!!Ka_JY85zDv0FFw!lyXCKYwFFb1EJMWtlRibvkhejSshLs9io19O2tXxARr6PBmYtLEHUaVbI78QLiYc4zlnavMz4c_lvaCfGFsXv71IrMk$>
Would it make sense to just do these insertions all at the end
That might work, but I really want to make the pre-processor simpler, not
more complicated. It is really making me nervous these days.
Now I'm wondering - why use -assembly at all? The publisher variable is
great, and is globally available. Once into a block, test its @xml:id
against the variable, and maybe drop a \newpage. A template can do this,
it just needs to be applied in each block. This is strictly a LaTeX thing -
so why not keep it all in the LaTeX conversion? Conversely, why test for
these page breaks every single time we apply a stylesheet, such as the
extract-*.xsl suite?
—
Reply to this email directly, view it on GitHub
<https://urldefense.com/v3/__https://github.com/PreTeXtBook/pretext/pull/2618*issuecomment-3226206742__;Iw!!Ka_JY85zDv0FFw!lyXCKYwFFb1EJMWtlRibvkhejSshLs9io19O2tXxARr6PBmYtLEHUaVbI78QLiYc4zlnavMz4c_lvaCfGFsXv71IrMk$>,
or unsubscribe
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABEDOACKUEC6WPMM52V773T3PTZZPAVCNFSM6AAAAACB5EFWHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMRWGIYDMNZUGI__;!!Ka_JY85zDv0FFw!lyXCKYwFFb1EJMWtlRibvkhejSshLs9io19O2tXxARr6PBmYtLEHUaVbI78QLiYc4zlnavMz4c_lvaCfGFsXuJDH2Dw$>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Yes, that was a good idea. A clever idea. Maybe too clever. ;-) -assembly is too popular and getting too complicated. I've got plans to give it a good once over... |
|
I am looking at this, and have partial work to turn it into the version where this thread left off back in August. There would be no more involvement with -assembly. Instead, each and every template in -latex where it is reasonable for the publisher to have indicated there should be a pagebreak, there will be a call to a template that prints a I've hit an issue when I reached Should -assembly carry the |
|
Same question for |
|
A different question while I was working on this, much less important than the first question. In -latex, there are a few templates that match on |
|
Legality of
|
|
Go ahead and move to
|
OK, thanks. I was already planning for that based on earlier conversations about all this during the summer. My question is different. Say an author makes a |
|
Sorry, didn't reread the question. Yes, copy it onto the |
f18d87f to
2d24dbc
Compare
|
This has now been force pushed, to cleanly get past all the merge conflicts since August. I could close this and open a new PR if that's better. #2740 should be reviewed before this one. For the life of me I can never remember the preferred order of xsl, documentation, and sample article commits. If I have these in the wrong order, say the word. I know enough to consult
It occurred to me that this is a larger issue than just videos in a sidebyside. The last paragraph about this feature in the guide brings attention to this. I didn't go so far as to use a |
Draft PR.
This lets publishers specify xml:ids for where they want additional page breaking to occur. There are two issues to sort out yet, and I feel that the discussion has reached the point where it may help to see some code.
xsltFreeStackElem: Unexpected RVT flag 3. I can't sort out what it is telling me, or how my usage of things here differs from elsewhere in the code base. Alert notwithstanding, everything "works" in the sense that page breaks come out where specified.