-
Notifications
You must be signed in to change notification settings - Fork 220
Responsive sizing option for interactives #2590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Responsive sizing option for interactives #2590
Conversation
|
Draft for now... |
|
Just so this is not forgotten, is there any progress on this? ;-) Thanks! |
|
This is still on my radar. There was this additional discussion on the -dev mailing list: There have been a lot of other PRs in the queue (both my queue and the general one). On the scale "Makes the interactives completely unusable" to "It could be slightly prettier", where does the current behavior rank for what you are trying to do? |
|
It's not a huge deal (so definitely not "unusable") in the current form - but I'd say it's a bit more serious than just "could be prettier": Even if I agree with Rob (from the -dev discussion) that in principle, students should be encouraged to use a "bigger" device/screen for serious work, I think the reality is that they more often than not revert to using their phones. Even I myself often use my phone to quickly check something before a class - and having an oversized interactive can have some cumbersome effects - see my next point below: One problem I haven't seen mentioned yet with the current design (where the interactive is larger than the container on small screens), is that scrolling (by swiping) the main page suddenly produces unwanted behaviour, as one is almost forced to scroll on the interactive - but that can (in my case) scroll inside the interactive, instead of the actual page. All this to say, I think this PR (and a fully responsive design) is important - and I personally like what it does, especially with the added configuration you discussed on the -dev group:
In any case, thanks so much for working on this! |
8ba40e6 to
136656a
Compare
150be29 to
3ecd557
Compare
3ecd557 to
1b72574
Compare
|
Updated, rebased, force pushed. Ready for review. Updated website sample here: Second page has some new demos of the responsive vs fixed layout options. Will also post on -dev |
Motivated by:
https://mail.google.com/mail/u/0/#search/interactives/FMfcgzQbfxdJxxTPHVVmjpTkClctsRZC
Discussed:
https://mail.google.com/mail/u/0/#search/interactives/KtbxLwHPwxLFDrvvqwrQDTtCGWSBRjZXpL
Sample of final behavior:
https://computerscience.chemeketa.edu/ascholer/pretext-test/interactives/section-interactive-server.html