Remove ui-helpers link#29
Open
Mahinsa-Wattegedara wants to merge 1 commit intoPraveen-R-2518:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the shared UI helper functions for universities and inlines their logic directly into the relevant pages. The code for determining university image paths, locations, and descriptions has been moved from the deleted
includes/ui-helpers.phpfile intouniversities.phpanduniversity.php, resulting in more explicit and page-specific logic. The most important changes are as follows:Removal of shared helpers:
includes/ui-helpers.phpfile, which previously contained helper functions for university image paths, locations, descriptions, and types. Calls to these functions were removed fromuniversities.phpanduniversity.php. [1] [2] [3]Image path logic refactoring:
universities.php, the logic for selecting a university's image is now implemented inline, using a$universityImageMapand a series of fallback checks for image files, instead of the previous helper function. [1] [2]Description and location logic refactoring:
universities.phpanduniversity.php, including truncation and default values, instead of relying on helper functions. [1] [2] [3]These changes increase code duplication but make the logic more visible and customizable within each page.