Skip to content

Add ability to specify a path on Ingress objects for Jira and Confluence helm charts. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Atchuu wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add ability to specify a path on Ingress objects for Jira and Confluence helm charts. #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77d9898
Adding path as an available option to the ingress.
Nov 13, 2019
ec3357d
Adding path as an available option to the ingress.
Nov 13, 2019
1cf9ad1
Disabling path by default for Confluence
Nov 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions confluence/templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@ spec:
- host: {{ .Values.Ingress.Host }}
http:
paths:
{{- if .Values.Ingress.Path }}
- path: {{ .Values.Ingress.Path }}
{{- else }}
- path: /
{{- end }}
backend:
serviceName: {{ .Release.Name }}
servicePort: {{ .Values.Ingress.ServicePort }}
Expand Down
2 changes: 2 additions & 0 deletions confluence/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ Ingress:
ServicePort: 8090
# Annotations:
# - key: value
# Optional: Define a path to use in the ingress
# Path: /confluence

PodDisruption:
Enabled: false
Expand Down
6 changes: 5 additions & 1 deletion jira/templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,12 @@ spec:
rules:
- host: {{ .Values.Ingress.Host }}
http:
paths:
paths:
{{- if .Values.Ingress.Path }}
- path: {{ .Values.Ingress.Path }}
{{- else }}
- path: /
{{- end }}
backend:
serviceName: {{ .Release.Name }}
servicePort: {{ .Values.Ingress.ServicePort }}
Expand Down
2 changes: 2 additions & 0 deletions jira/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ Ingress:
Enabled: true
Host: jira.example.com
ServicePort: 8080
# Optional: Define a path to use in the ingress
# Path: /jira

# to add promethues annotations
PrometheusMetrics:
Expand Down